Skip to content
This repository was archived by the owner on Aug 19, 2019. It is now read-only.

Conversation

@davidbtucker
Copy link
Contributor

@davidbtucker davidbtucker commented May 30, 2018

No description provided.

Copy link
Contributor

@bmoyles0117 bmoyles0117 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@davidbtucker davidbtucker force-pushed the davidbtucker-env-tests branch from 340ecb8 to f41a679 Compare July 17, 2018 18:27
@davidbtucker davidbtucker changed the base branch from davidbtucker-http-mocks to master July 17, 2018 18:28
Copy link
Contributor

@igorpeshansky igorpeshansky left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM :shipit:

@igorpeshansky igorpeshansky changed the title Add more tests for environment.cc, for reading values from both confi… Add more tests for environment.cc, for reading values from both config or metadata server. Jul 17, 2018
@davidbtucker davidbtucker merged commit 9f4867a into master Jul 17, 2018
@davidbtucker davidbtucker deleted the davidbtucker-env-tests branch July 17, 2018 18:45
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants