This repository was archived by the owner on Aug 19, 2019. It is now read-only.
The entrypoint script uses bash expressions, so should be run with /bin/bash. #161
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jkohen
approved these changes
Jul 12, 2018
jkohen
left a comment
jkohen
left a comment
There was a problem hiding this comment.
Assuming /bin/bash is always available in the Dockerfile-xenial base image, this makes sense to me.
It'd be good to document what the bashisms are, if you've already identified them. Otherwise no worries.
Contributor
Author
|
Addressed comments. PTAL. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.