Make the credentials file optional. #30
Conversation
| namespace { | ||
|
|
||
| json::value ReadCredentials(const std::string& credentials_file) throw(json::Exception) { | ||
| class NoCredentials { |
There was a problem hiding this comment.
The spacing for this class seems unusual. Is that on purpose? Also, how about naming this NoCredentialsException?
There was a problem hiding this comment.
This is just an informational class to convey a specific (non-exceptional) status. The code catches and ignores it, modulo info logging.
What's unusual about the spacing?
There was a problem hiding this comment.
Per conversation offline, this is the expected formatting. public and private should have one-space indentation per convention.
There was a problem hiding this comment.
For reference: https://google.github.io/styleguide/cppguide.html#Class_Format.
| namespace { | ||
|
|
||
| json::value ReadCredentials(const std::string& credentials_file) throw(json::Exception) { | ||
| class NoCredentials { |
There was a problem hiding this comment.
Per conversation offline, this is the expected formatting. public and private should have one-space indentation per convention.
3 participants
No description provided.