Skip to content
This repository was archived by the owner on Aug 19, 2019. It is now read-only.

Conversation

@dhrupadb
Copy link
Contributor

No description provided.

Copy link
Contributor

@igorpeshansky igorpeshansky left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do our CentOS vendored boost libraries already include program-options?

README.md Outdated
1. Install runtime dependencies:

$ sudo apt-get install libyajl2 libboost-system1.55.0 libboost-thread1.55.0
$ sudo apt-get install libyajl2 libboost-program-options-1.55.0 \
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Does this mean we also need to add this to the package requires?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes. Updated PR.

Copy link
Contributor Author

@dhrupadb dhrupadb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

PTAL. For CentOS it doesn't look like we need it somehow.

README.md Outdated
1. Install runtime dependencies:

$ sudo apt-get install libyajl2 libboost-system1.55.0 libboost-thread1.55.0
$ sudo apt-get install libyajl2 libboost-program-options-1.55.0 \
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes. Updated PR.

Copy link
Contributor

@igorpeshansky igorpeshansky left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM :shipit:

@dhrupadb dhrupadb merged commit acb8d79 into igorp-verbose-logging Oct 23, 2017
@dhrupadb dhrupadb deleted the dhrupadb-fix-readme branch October 23, 2017 16:21
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants