-
Notifications
You must be signed in to change notification settings - Fork 11
Add libboost-program-options to runtime dependencies. #38
Conversation
igorpeshansky
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Do our CentOS vendored boost libraries already include program-options?
README.md
Outdated
| 1. Install runtime dependencies: | ||
|
|
||
| $ sudo apt-get install libyajl2 libboost-system1.55.0 libboost-thread1.55.0 | ||
| $ sudo apt-get install libyajl2 libboost-program-options-1.55.0 \ |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Does this mean we also need to add this to the package requires?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yes. Updated PR.
dhrupadb
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
PTAL. For CentOS it doesn't look like we need it somehow.
README.md
Outdated
| 1. Install runtime dependencies: | ||
|
|
||
| $ sudo apt-get install libyajl2 libboost-system1.55.0 libboost-thread1.55.0 | ||
| $ sudo apt-get install libyajl2 libboost-program-options-1.55.0 \ |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yes. Updated PR.
igorpeshansky
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM ![]()
No description provided.