This repository was archived by the owner on Aug 19, 2019. It is now read-only.
Disable Kubernetes polling by default (only use watch). #60
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
LGTM. |
bmoyles0117
reviewed
Feb 24, 2018
Contributor
bmoyles0117
left a comment
bmoyles0117
left a comment
There was a problem hiding this comment.
I'm concerned about setting this as the default, so long as we have the issue with the resource metadata api. Our current implementation does indeed break a user's expected experience when pods and nodes essentially disappear after 2 hours. The change itself LGTM, but I'm not comfortable with it in the current state.
Contributor
Author
|
I thought the issue has been fixed already on the Resource Metadata API side. |
igorpeshansky
force-pushed
the
master
branch
from
70449da to
5aa2078
Compare
Contributor
Author
|
@bmoyles0117 approved verbally offline. Merging. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.