This repository was archived by the owner on Aug 19, 2019. It is now read-only.
Factor out event processing from Watcher, leaving only the chunk assembling code. #66
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
supriyagarg
approved these changes
Mar 7, 2018
Contributor
supriyagarg
left a comment
supriyagarg
left a comment
There was a problem hiding this comment.
The changes look fine to me.
Bug fix in a separate PR sounds fine - along with a unit test around the bug :)
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR is a pure refactoring. I think this exposed a bug in the chunk encoding processing code, which I can fix in a later PR or here. There is also an API bug in
cpp-netlibthat I hope to fix upstream, which will let me handle HTTP response status in the callback, but, again, probably not in this PR.