This repository was archived by the owner on Aug 19, 2019. It is now read-only.
Replace all std::bind instances with lambda expressions. #74
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bmoyles0117
approved these changes
Mar 13, 2018
Contributor
bmoyles0117
left a comment
bmoyles0117
left a comment
There was a problem hiding this comment.
I like these changes! LGTM
supriyagarg
approved these changes
Mar 13, 2018
Contributor
supriyagarg
left a comment
supriyagarg
left a comment
There was a problem hiding this comment.
A minor comment. Otherwise these changes look great!
src/kubernetes.cc
Outdated
| @@ -1157,12 +1160,15 @@ void KubernetesUpdater::StartUpdater() { | |||
| config().KubernetesClusterLevelMetadata() ? "" : current_node); | |||
|
|
|||
| // Wrap the bind expression into a function to use as a bind argument. | |||
Contributor
There was a problem hiding this comment.
Update this comment to mention lambda expression rather than bind.
Contributor
Author
There was a problem hiding this comment.
The comment is outdated. I just removed it.
igorpeshansky
commented
Mar 13, 2018
src/kubernetes.cc
Outdated
| @@ -1157,12 +1160,15 @@ void KubernetesUpdater::StartUpdater() { | |||
| config().KubernetesClusterLevelMetadata() ? "" : current_node); | |||
|
|
|||
| // Wrap the bind expression into a function to use as a bind argument. | |||
Contributor
Author
There was a problem hiding this comment.
The comment is outdated. I just removed it.
Contributor
|
Thanks. LGTM |
Contributor
Author
|
Sigh. Merged into the wrong branch. It's ok, we'll pick this up once #73 is merged. |
igorpeshansky
added a commit
that referenced
this pull request
Mar 18, 2018
This is a cherry-pick of #74 into master.
igorpeshansky
added a commit
that referenced
this pull request
Mar 18, 2018
This is effectively a cherry-pick of #74 into master.
igorpeshansky
added a commit
that referenced
this pull request
Mar 19, 2018
This is effectively a cherry-pick of #74 into master.
Contributor
Author
|
Superseded by #83. |
igorpeshansky
added a commit
that referenced
this pull request
Mar 22, 2018
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.