Skip to content

fix(NFS-1978): make types optional to fix runtime errors #28

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
Ninerian merged 2 commits into from
Dec 19, 2022
Merged

fix(NFS-1978): make types optional to fix runtime errors #28

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
359847e
fix(NFS-1978): make types optional to fix runtime errors
Ninerian Dec 19, 2022
eca48ad
chore: raise version
Ninerian Dec 19, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion composer.json
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
{
"name": "staffbase/plugins-sdk-php",
"version": "2.1.1",
"version": "2.1.2",
"type": "library",
"description": "Staffbase PHP SDK library for plugins.",
"keywords": ["staffbase", "plugins", "library", "php", "sdk"],
Expand Down
10 changes: 4 additions & 6 deletions src/SSOData/SSODataTrait.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -27,11 +27,9 @@ trait SSODataTrait
/**
* Get the branch id of the app that issued the token.
*
* The id will always be present.
*
* @return string
* @return null|string
*/
public function getBranchId(): string
public function getBranchId(): ?string
{
return $this->getClaimSafe(SSODataClaimsInterface::CLAIM_BRANCH_ID);
}
Expand Down Expand Up @@ -61,9 +59,9 @@ public function getSessionId(): ?string
*
* The id will always be present.
*
* @return string
* @return null|string
*/
public function getInstanceId(): string
public function getInstanceId(): ?string
{
return $this->getClaimSafe(SSODataClaimsInterface::CLAIM_INSTANCE_ID);
}
Expand Down