This repository was archived by the owner on Sep 16, 2025. It is now read-only.
Conversation
Contributor
|
Thank you for the addition, std::format is definitely worth switching to, considering that po3 also PR'd std::format counterpart when they added the FORM_TYPE formatter, so there's nothing stopping us from doing so. |
gottyduke
approved these changes
Sep 14, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When
SFSE::Initis used, it will now initialize a default spdlog logger.This behavior can be turned off by passing false as the optional second argument:
...if you have no need for a log file at all. Keep in mind that this sets the default logger for the module (plugin), you can still modify it's behavior through the spdlog api, such as setting the level, or the pattern.
Some keen eyed may notice that I am also registering an msvc sink, this will not impact performance as spdlog as of a somewhat recent version now checks if a debugger is attached, and if not, the sink is essentially a no-op, with no real cost to performance.
You can test this pr with the xmake template by specifying the
dev/qdx/loggingbranch.