Conversation
There was a problem hiding this comment.
Pull request overview
This PR refactors error handling by replacing AxError::Other(LinuxError::*) with AxError::from(LinuxError::*) across the codebase, updates dependency versions (axerrno to 0.2, axio to 0.2), and removes crates-io patches in favor of direct dependencies. Additionally, it updates a console API call from irq_number() to irq_num() and removes an unnecessary type cast.
- Standardizes error conversion using
Fromtrait instead ofOthervariant - Updates dependencies to version 0.2 and removes patch overrides
- Refactors console IRQ API usage
Reviewed changes
Copilot reviewed 9 out of 10 changed files in this pull request and generated no comments.
Show a summary per file
| File | Description |
|---|---|
| arceos | Updates subproject commit reference |
| api/src/vfs/dev/tty/ntty.rs | Updates console IRQ function name and removes type cast |
| api/src/vfs/dev/loop.rs | Converts error handling to use From trait |
| api/src/syscall/task/wait.rs | Converts error handling to use From trait |
| api/src/syscall/sync/futex.rs | Converts error handling to use From trait |
| api/src/syscall/net/socket.rs | Converts error handling to use From trait |
| api/src/syscall/net/opt.rs | Converts error handling to use From trait |
| api/src/socket.rs | Converts error handling to use From trait |
| Cargo.toml | Updates dependency versions and removes patch section |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
ccd18e3 to
1919bf6
Compare
There was a problem hiding this comment.
Pull request overview
Copilot reviewed 13 out of 14 changed files in this pull request and generated 3 comments.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
No description provided.