Merged
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
This PR updates the arceos submodule and makes corresponding type casting adjustments in the socket implementation to maintain compatibility. A build configuration for the VisionFive 2 platform is also simplified.
- Updated arceos submodule to commit c67b5ec
- Added explicit type casts for
svm_cidfield conversions in VsockAddr implementation - Simplified VisionFive 2 feature configuration by removing GPT-specific driver dependency
Reviewed changes
Copilot reviewed 3 out of 4 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| arceos | Submodule updated to newer commit |
| api/src/socket.rs | Added type casts for svm_cid field in VsockAddr conversions |
| Cargo.toml | Simplified vf2 feature from driver-sdmmc-gpt to driver-sdmmc |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Note on the previous
sdmmc-gptdriver here: we'll add gpt partition feature back in axfs-ng later.