Merged
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
This PR simplifies the TaskExt implementation by leveraging Rust's orphan rule exemption for fundamental types like Box<T>. The refactoring eliminates the ThreadInner/Thread wrapper pattern by implementing TaskExt directly on Box<Thread>.
Key changes:
- Renamed
ThreadInnertoThreadand removed the wrapper type - Changed
TaskExtimplementation fromThreadtoBox<Thread> - Modified
Thread::new()to returnBox<Thread>directly
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Mivik
approved these changes
Dec 1, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I didn't know that orphan rules do not consider
Box<T>as a remote type. See https://doc.rust-lang.org/reference/items/implementations.html#r-items.impl.trait.fundamental.