Conversation
Co-authored-by: Stasshe <133995608+Stasshe@users.noreply.github.com>
Co-authored-by: Stasshe <133995608+Stasshe@users.noreply.github.com>
Co-authored-by: Stasshe <133995608+Stasshe@users.noreply.github.com>
Co-authored-by: Stasshe <133995608+Stasshe@users.noreply.github.com>
Copilot
AI
changed the title
[WIP] Fix inline highlighter quote handling issues
Fix inline highlighter quote handling for Shell and JS/TS nested expressions
Dec 3, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Shell strings containing
$()or${}and JS/TS template literals with nested${}caused "phase reversal" - content inside and outside quotes was incorrectly swapped. The regex-based tokenizer couldn't handle nested structures.Changes
Shell/Bash (
bash,sh,zsh,fish):parseShellDoubleQuotedString: Handles$(),${}, backticks, escapes within double-quoted stringsparseShellCommandSubstitution: Handles nested parens and quotes inside$()tokenizeShell: State-based tokenizer replacing regex for stringsJavaScript/TypeScript (
js,ts,jsx,tsx, etc.):parseJsTemplateString: Handles${}interpolation in template literalsparseJsTemplateExpression: Handles nested templates, strings, braces inside${}tokenizeJsTs: State-based tokenizer for template literalsThe
tokenize()function now dispatches to language-specific tokenizers based on the language parameter.Original prompt
✨ Let Copilot coding agent set things up for you — coding agent works faster and does higher quality work when set up for your repo.