Fix Monaco theme handling for DiffTab consistency#136
Merged
Conversation
- Changed from defining separate pyxis-dark/pyxis-light themes to a single pyxis-custom theme
- pyxis-custom theme now dynamically adapts based on colors (light/dark detection)
- Added cache key based on editor-related color properties to avoid unnecessary re-definitions
- Theme is only re-defined when relevant color properties change
- setTheme('pyxis-custom') is called on every mount to ensure consistency
Co-authored-by: Stasshe <133995608+Stasshe@users.noreply.github.com>
- Use LIGHT_THEMES list to determine light/dark theme - Accept themeName parameter instead of computing from colors - Remove getColorsCacheKey function and use themeName for caching - Update all callers to pass themeName from useTheme() Co-authored-by: Stasshe <133995608+Stasshe@users.noreply.github.com>
Copilot
AI
changed the title
[WIP] Fix theme reset issue in diff tab
Fix Monaco theme handling for DiffTab consistency
Dec 3, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
DiffTab wasn't applying themes correctly when switching tabs, while CodeEditor worked fine. Root cause: theme names mismatched - components used
theme="pyxis-custom"butmonaco-themes.tsdefinedpyxis-dark/pyxis-light.Changes
pyxis-customtheme matching component propsLIGHT_THEMESlist withthemeNameinstead of computing from colorsthemeNamechangesUpdated callers (MonacoEditor, DiffTab, AIReviewTab) to pass
themeNamefromuseTheme().Original prompt
💬 We'd love your input! Share your thoughts on Copilot coding agent in our 2 minute survey.