feat: add christmas 2025 theme #806
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
There was a problem hiding this comment.
Pull request overview
This PR adds a Christmas 2025 theme by introducing festive gift box styling to the rendering system. The changes transform all boxes into wrapped present designs with ribbons, patterns, and themed colors. However, the implementation replaces the entire box rendering system globally rather than adding an opt-in theme, which introduces several breaking changes and concerns.
Key Changes
- Added Christmas present styling with ribbons, patterns (stripes, dots, hearts, checkers), and two color schemes (red/green and yellow/red)
- Modified global rendering behavior including darker text shadows and gradient effects on characters
- Increased all box padding by 4 pixels to accommodate the new design
- Updated character widths in sizes.json
Reviewed changes
Copilot reviewed 8 out of 8 changed files in this pull request and generated 9 comments.
Show a summary per file
| File | Description |
|---|---|
| packages/rendering/src/jsx/types.ts | Added boxColorId to theme context types to support color variation |
| packages/rendering/src/jsx/render.ts | Added random color selection for boxes at render time |
| packages/rendering/src/intrinsics/Box.ts | Completely replaced box rendering with Christmas present design including patterns and ribbons |
| packages/rendering/src/font/font-renderer.ts | Changed text shadow brightness and added gradient effects to characters |
| packages/rendering/sizes.json | Updated character width mappings for font rendering |
| apps/discord-bot/src/themes/index.ts | Set boxColorId to undefined in theme context |
| apps/discord-bot/src/components/Table/TableSeparator.tsx | Formatting improvements (ternary operator spacing) |
| apps/discord-bot/src/commands/blitzsg/blitzsg.profile.tsx | Formatting improvements (multi-line JSX attributes) |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.