Cap home dependency version below 5.11#123
Closed
dburgener wants to merge 1 commit intoStebalien:masterfrom
Closed
Cap home dependency version below 5.11#123dburgener wants to merge 1 commit intoStebalien:masterfrom
dburgener wants to merge 1 commit intoStebalien:masterfrom
Conversation
Home released version 5.11 bumping the msrv to rust 1.81. They justify such an aggressive msrv policy by stating that users should not be using the home crate at all, but instead should rely on the standard library home_dir function. That function has a bug that is not fixed until 1.85, which prevents it from being an option for lower rust versions. To mitigate, just pin to an older home version for now.
dburgener
added a commit
to dburgener/lalrpop
that referenced
this pull request
Dec 17, 2024
This works around the home MSRV bump until a long term solution is available. See discussion at: lalrpop#1015 Stebalien/term#123 rust-lang/cargo#13270
dburgener
added a commit
to dburgener/lalrpop
that referenced
this pull request
Dec 17, 2024
This works around the home MSRV bump until a long term solution is available. See discussion at: lalrpop#1015 Stebalien/term#123 rust-lang/cargo#13270
Owner
|
You can downgrade it in your own crate. If I cap this here, nobody else will be able to upgrade it if they want the latest version. |
Author
|
Thanks for your consideration. Will you be bumping the msrv for this crate to 1.81? It no longer builds on versions below 1.81 due to the home dependency. |
Owner
|
You can build this crate with 1.63, you just need to constrain the |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Home released version 5.11 bumping the msrv to rust 1.81. They justify such an aggressive msrv policy by stating that users should not be using the home crate at all, but instead should rely on the standard library home_dir function. That function has a bug that is not fixed until 1.85, which prevents it from being an option for lower rust versions.
To mitigate, just pin to an older home version for now.