chore(deps): remove deprecated home::home_dir()#127
chore(deps): remove deprecated home::home_dir()#127Stebalien merged 2 commits intoStebalien:masterfrom
Conversation
|
Thanks but I'm tracking the rust version available in debian stable at the moment. Once debian trixie becomes stable, I'll the MSRV in both this crate and tempfile (addressing all the lints, etc. at the same time). |
|
Did you check my changes? |
|
OH! I'm sorry, I misread that. |
|
Ah, now I remember why I didn't do this. From https://doc.rust-lang.org/std/env/fn.home_dir.html#windows:
However, that only applies to very specific Windows environments, not Debian. |
|
Great, I just saw stable since = "1.0.0" but not for exotic windows environments :( Can we assume that |
Probably not. BUT we don't really need to support rust 1.63 on Windows (I'll document the differences). |
|
Hm. Apparently the readme already has the following caveat:
So this is really a non-issue on Windows. |
|
Great to hear that no users would be affected! |
Chores
home::home_dir()byenv::home_dir()home0.5.11 bumped to 1.81)windows-sysremains)calling .bytes()remains to be fixed)Deprecations
rust-lang/cargo#14939
https://github.com/rust-lang/cargo/blob/master/crates/home/README.md?plain=1#L20