Ditch the wandEnabled option in the config#388
Ditch the wandEnabled option in the config#388RickyB98 wants to merge 1 commit intoSteffion:masterfrom
Conversation
The option 'wandEnabled' has been removed from the default config, adding it does not enable the command, and it's the only command that still has that check (which is already performed by W.config.get(ConfigC.commandEnabled_wand)). Removing the if clause.
|
I don't understand why you would remove this? |
|
Because it is redundant. All BlockHunt commands except 'wand' have their own checks, while 'wand' has this extra check in the config. When the plugin is loaded, /bh wand does not work, the console says that the command does not exist. Removing this check enables this function, which can be disabled from the already present "commandEnabled" block in the config. (for the record, I couldn't fix the error without recompiling the plugin with this change) |
|
My bad, the "wandEnabled" option is present in the config, but it is still redundant, because there's also "commandEnabled: wand: true", which is overridden by wandEnabled. |
|
Not only the command gets disabled with wandEnabled, but it also disables the fact that you have to set corner positions. commandEnabled only disables the command itself, while wandEnabled also disables setting points and moving out of the arena. |
|
I might not be an expert user of this plugin (in fact, I'm the back-end guy in our server), but I don't understand what the point is in keeping corner setting on without turning the command to get the wand on too... |
|
wandEnabled disables the corner setting and the command. commandEnabled only disables the command. So there is a difference in usage. I don't think I will merge this request, sorry. |
2 participants
The option 'wandEnabled' has been removed from the default config, adding it does not enable the command, and it's the only command that still has that check (which is already performed by W.config.get(ConfigC.commandEnabled_wand)). Removing the if clause.