Apply advantage and disadvantage properly

[Foxaramar]

At the moment advantage and disadvantage is applied as a flat modifier, when it would be better if we had the option for it to be actually rolled. Furthermore, when making a macro, it would be really nice to be able to apply advantage and disadvantage, or even versatile via the ctrl, alt and shift keys, rather than having to make separate macros for each scenario. Perhaps this is only possible if you use Mob Attack with Midi-QOL, but for those of us that use both, this would be an amazing upgrade to what the module can do.

[Stendarpaval]

Advantage and disadvantage are only applied as a flat modifier for the "Mob Rules" setting, where no actual dice are rolled and only the number of attacks, attack bonus, and target AC are considered. Maybe I should make this more clear in the settings' hint text...

For the "Roll Attacks Individually" setting, d20s are rolled for attack rolls with proper advantage and disadvantage.

Interesting idea to detect keys being pressed for advantage / disadvantage and maybe also versatile damage when executing macros. I'll look into that, might take a few weeks though due to more limited free time. Whether that requires Midi-QOL or not remains to be seen, though I could also make use of the keybind-lib library module.

Thanks for the feedback and ideas!

Edit: note to self based on the Discord discussion, also add a marker to chat messages that indicates whether a mob attack was rolled with advantage / disadvantage

[Stendarpaval]

Release 0.3.5 allows you to export macros that roll with advantage if the alt key is held down and with disadvantage if the Command key (MacOS) or probably Ctrl key (Windows) is held down. I'm afraid I didn't have enough time to also add a key for versatile damage, since that's a somewhat more complicated problem to solve.

Oh, and this doesn't rely on Midi-QOL or anything else. It's just default Foundry. I suspect that the disadvantage key might be a bit of an issue on Windows, but I didn't have time to check. Could you let me know if it works for you?

Also, if you now hover over the attack roll results, the tooltip will say whether that attack roll was rolled with advantage/disadvantage.

[Kinthos723]

The macro that is exported does not work with Windows using the Ctrl key to roll with disadvantage. A user can change the macro that was exported and change the disadvantage line with Command key to Ctrl key instead and save the modified line and it works fine for Windows users then.

It's neat that players can be allowed to use the tool, but is it possible to make it so they can roll at advantage or disadvantage themselves when using the tool themselves?

[Stendarpaval]

@Kinthos723 I just released v0.3.7 which solves the issues you've been having. Namely, if you set the new Disadvantage keybinding setting to "ctrl", then newly exported macros will use the ctrl key. In addition, holding down either alt or ctrl when executing mob attacks in the dialog should also properly roll the attacks with advantage or disadvantage respectively. You can verify this by hovering your cursor over the attack roll values. The tooltip should indicate whether it was rolled with advantage or disadvantage.

[NateHawk85]

Not to pile on here, but could that reflect in the chat output as well? I have the "Roll Attacks Individually" setting enabled, but as it is currently, it can be a little confusing to know whether or not it was rolled with proper advantage/disadvantage. Right now, rolling with advantage/disadvantage only shows the "result" roll instead of both dice rolls. While hovering over it does show the "(Disadvantage)" text after the attack text with bonus, it would be nice to perhaps show all dice rolls instead with some sort of separator, maybe?

For example, in the above image, I have 2 cultists making scimitar attacks at a PC. Instead of showing the final "5 16", it could instead show "5 13 | 20 16" or something along those lines? :)

Regardless, thank you again for all the work you've put into this module!

[Stendarpaval]

@NateHawk85 That's a pretty good idea! To be completely honest, I originally wanted to replicate the collapsed roll results html + css used in the dnd5e system. While investigating how to do so, I stumbled upon the current implementation which was simpler and fulfilled the feature request at the time (which I now remember you made in issue #17 😄).

I ran out of time back then to complete the ideal implementation, and unfortunately I don't have much time nowadays too. Having said that, something like "5 13 | 20 16" isn't too hard to implement - but it would probably become really cluttered as the number of attacks increases. And the message would grow bigger, taking up more space in the chat log. 🤔

In the end, I've already used two placeholder implementations for showing roll results and am not keen on continually tweaking it. I've decided to continue to figure out how to properly replicate the collapsible results and thus implement the ideal way to show roll results. I'll try to start on that this weekend, but given my current workload it could take a few weeks to implement.

[NateHawk85]

No worries! I completely understand. And honestly, it's not a huge deal or anything, just a preference thing :) Regardless, thank you so much for all your work on this module! It's saved our group so much time when running encounters with large groups of enemies. Definitely one of my core modules now.

[Stendarpaval]

@NateHawk85 So in the newly released v0.3.12 hovering over the roll result will now also show the discarded result if said roll was made with advantage/disadvantage. It's not the ideal solution I wanted, which I actually have worked on and off on, but it's a minor improvement.

I'm afraid my css skills are insufficient to whip up a proper method to display it, and as you can read in the release notes, I sadly don't have time to work on new features anymore.