Added em tag#47
Merged
Merged
Conversation
Stephanevg
requested changes
Oct 4, 2018
Owner
Stephanevg
left a comment
There was a problem hiding this comment.
Hi @awickham10
Thanks a lot for your PR ! It is perfect!
Could ask you one very small change before merging it?
I noticed the help is still the one for the "
" element
<#
.SYNOPSIS
Generates em HTML tag.
.Description
This tag is a "Textual semantic" tag. To use it in a "P" tag, be sure to prefix it with a semicolon (";").
See example for more details.
.EXAMPLE
p{
"This is";em {"cool"}
}
Will generate the following code
<p>
This is
<em>
cool
</em>
</p>You can find infos here to update it accordingly:
https://www.w3schools.com/tags/tag_em.asp
This should be done in not time.
Keep them comming 👍 !
Contributor
Author
|
Is this more what you were thinking? .SYNOPSIS
Generates em HTML tag.
.Description
This tag is a phrase tag. It renders as emphasized text.
.EXAMPLE
p{
"This is";em {"cool"}
}
Will generate the following code
<p>
This is
<em>
cool
</em>
</p> |
Owner
|
Yeah, that is great! I think we should leave the possibility for the end user to set an em element with an empty value. (and modified using Javascript in a later step for example). |
Contributor
Author
|
Done! |
Owner
|
Awesome, Thanks a lot for your PR @awickham10 ! |
100 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Pull Request added em tag
Added em tag based on strong tag function.
Please tell us , the type of Change you are submitting:
Select one of the following:
Does it fix an existing issue? Please tell us which one
Contributes to issue #7.
Description of what's been changed
Added em.ps1 function and tests.
Results of your tests (If applicable)