Skip to content

Added VSCode snippets and function to install them#89

Merged
Stephanevg merged 1 commit into
Stephanevg:masterfrom
FishFenly:vscode-snippets
Oct 17, 2018
Merged

Added VSCode snippets and function to install them#89
Stephanevg merged 1 commit into
Stephanevg:masterfrom
FishFenly:vscode-snippets

Conversation

@FishFenly
Copy link
Copy Markdown
Contributor

Pull Request [Added VSCode snippets]

I've added 3 VSCode snippets using the examples in the master repository.
I've also created a function and corresponding pester test to install the snippets

Please tell us , the type of Change you are submiting:

Select one of the following:

[ ] Bug
[ x ] Feature
[ ] Minor Change

Does it fix an existing issue? Please tell us which one

Resolves #45

Results of your tests (If applicable)

image

@Stephanevg Stephanevg merged commit 368b1e3 into Stephanevg:master Oct 17, 2018
@Stephanevg
Copy link
Copy Markdown
Owner

Thank you so much for your PR @FishFenly ! This is such a cool one!

Even tough the tests where failing, I am still merging it in dev,as I think this is really a nice feature to have.

The tests were actually testing if the snippets were present, instead, of testing the cmdlet in creating the snippets in the first place.

this is not a big deal, and I will correct this my self. I simply wanted to have this one merged quickly.

Thanks again ! 👍 👍

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Add Skeleton VSCode Snippets

2 participants