Skip to content
This repository was archived by the owner on May 5, 2021. It is now read-only.

FileListEntryModel now contain image URLs for each image#11

Closed
kevinruder wants to merge 1 commit intoSteveSandersonMS:masterfrom
kevinruder:AddedImageUrls
Closed

FileListEntryModel now contain image URLs for each image#11
kevinruder wants to merge 1 commit intoSteveSandersonMS:masterfrom
kevinruder:AddedImageUrls

Conversation

@kevinruder
Copy link

An image URL is created for each uploaded image, these can be used as sources in image tags allowing them to instantly be used without processing. The FileListEntryModel is expanded to include URL.

… sources in image tags. The FileListEntryModel is expanded to include URL
@daltskin
Copy link

Nice addition :)

@SteveSandersonMS
Copy link
Owner

Thanks for the suggestion!

Unfortunately this would cause performance issues, since the data URLs can be arbitrarily large. The intention is that any large blocks of data are not sent eagerly as part of the initial JSON block, but rather are available as streams for the .NET code to consume.

Instead of implementing it this way, please consider adding a .NET method to FileListEntry called something like ToDataUrlAsync that returns a Task<string>. That way, developers only call it if they really want the data URI, and don't pay the perf cost otherwise.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants