Skip to content

fix description markdown #160

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
Steven-Harris merged 1 commit into from
Mar 11, 2026
Merged

fix description markdown #160

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
88 changes: 40 additions & 48 deletions src/features/pr-review/PRDescription.svelte
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -10,56 +10,23 @@

let expanded = $state(false);

// Check if this looks like a dependabot or automated PR
const isAutomatedPR = $derived.by(() => {
const lowerTitle = title.toLowerCase();
const lowerBody = body.toLowerCase();
return (
lowerTitle.includes('dependabot') ||
lowerTitle.includes('bump') ||
lowerBody.includes('dependabot') ||
body.includes('## ') || // Has markdown headers
body.includes('| ') || // Has tables
body.length > 500
); // Very long description
});

// For automated PRs, show a much shorter preview
const previewLength = $derived.by(() => (isAutomatedPR ? 100 : 200));
const shouldShowToggle = $derived.by(() => body.length > previewLength);
const COLLAPSED_HEIGHT = 150; // px

const displayText = $derived.by(() => {
if (!shouldShowToggle || expanded) return body;
return body.substring(0, previewLength) + '...';
});

// Simple markdown-to-text converter for preview
function stripMarkdown(text: string): string {
return text
.replace(/#{1,6}\s/g, '') // Remove headers
.replace(/\*\*(.*?)\*\*/g, '$1') // Remove bold
.replace(/\*(.*?)\*/g, '$1') // Remove italic
.replace(/\[(.*?)\]\(.*?\)/g, '$1') // Remove links, keep text
.replace(/`(.*?)`/g, '$1') // Remove code formatting
.replace(/\|.*\|/g, '') // Remove table rows
.replace(/---+/g, '') // Remove horizontal rules
.replace(/\n{3,}/g, '\n\n') // Normalize line breaks
.trim();
}
const shouldShowToggle = $derived.by(() => body.length > 200);

// Configure marked options for security and styling
marked.setOptions({
breaks: true, // Convert line breaks to <br>
gfm: true, // GitHub Flavored Markdown
});

const cleanText = $derived.by(() => stripMarkdown(displayText));
// Always render the full markdown so tables/structure are never broken
const renderedMarkdown = $derived.by(() => {
try {
return marked.parse(displayText);
return marked.parse(body);
} catch (error) {
console.error('Error rendering markdown:', error);
return displayText;
return body;
}
});

Expand All @@ -80,18 +47,43 @@
</script>

<div class="mt-3">
{#if hasMarkdown}
<div class="gh-markdown prose prose-sm max-w-none prose-invert">
{@html renderedMarkdown}
</div>
{:else}
<div class="text-sm text-[#c9d1d9] whitespace-pre-line">
{cleanText}
</div>
{/if}
{#if shouldShowToggle}}
<div
class="relative"
class:collapsed={shouldShowToggle && !expanded}
>
{#if hasMarkdown}
<div class="gh-markdown prose prose-sm max-w-none prose-invert">
{@html renderedMarkdown}
</div>
{:else}
<div class="text-sm text-[#c9d1d9] whitespace-pre-line">
{body}
</div>
{/if}
{#if shouldShowToggle && !expanded}
<div class="collapsed-fade"></div>
{/if}
</div>
{#if shouldShowToggle}
<button onclick={() => (expanded = !expanded)} class="text-blue-600 hover:text-blue-800 text-sm mt-1 font-medium">
{expanded ? 'Show less' : 'Show more'}
</button>
{/if}
</div>

<style>
.collapsed {
max-height: 150px;
overflow: hidden;
}

.collapsed-fade {
position: absolute;
bottom: 0;
left: 0;
right: 0;
height: 50px;
background: linear-gradient(to bottom, transparent, var(--color-bg, #0d1117));
pointer-events: none;
}
</style>
Loading