Fix issue#16 refrencing issue #17 #19
Conversation
remove the dependency of metadata and arrayinterface and code is ready to use for julia >=1.10
|
@fjebaker and @matteobachetti your review required |
|
if needed later we can change the jullia version from project.toml since I don't want to interrupt current environments of workflow |
|
I've changed the base to the Julia formatted branch so stylistic diffs are removed. I'll resolve conflicts in a moment. |
kashish2210
force-pushed
the
fix_issue#16
branch
from
168a245 to
763552c
Compare
|
Hi @kashish2210 could you resolve the conflicts before I review this please? :) Force pushing removed the merge commit I'd added to resolve them previously. |
|
I'll take care of it soon and let you know once it's done. Sorry for the force pushing |
|
i have resolve conflicts |
fjebaker
left a comment
fjebaker
left a comment
There was a problem hiding this comment.
Thanks @kashish2210 this looks great! I'll try to run the tests locally soon, as I suspect the CI will be broken. I'll update the CI in due course with all the latest versions, and then we can get this merged in.
| silent::Bool = false, | ||
| ) | ||
| local_show_progress = show_progress | ||
| local_show_progress = silent ? identity : show_progress |
src/fourier.jl
Outdated
| flux_iterable2, | ||
| dt::Real; | ||
| norm::String = "frac", | ||
| function avg_cs_from_iterables_quick(flux_iterable1, flux_iterable2, |
There was a problem hiding this comment.
This looks like it needs code formatting. Could you run JuliaFormatter over this?
2 participants
Update Dependencies & GitHub Workflow for Newer Julia Versions
Summary
This PR updates the Stingray.jl project to enhance compatibility with newer Julia versions
for my workflow and see the test results please prefer my [NOTEBOOK]
Key Updates
🔹 Updated Julia Version Compatibility
🔹 Main improvements
Metadatadependency and replaced it withNamedTuplefor better performance and compatibility.normalize_periodogramsand other spectral analysis functions to ensure correctness across different normalization schemes.compare_tablesfunction for better reliability in test comparisons.PREVIEW AND TEST RESULTS
Looking forward to your feedback!