Adds stingray's logo and favicon in the documentation #707
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## main #707 +/- ##
=======================================
Coverage 97.21% 97.21%
=======================================
Files 42 42
Lines 7797 7797
=======================================
Hits 7580 7580
Misses 217 217 📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
ViratSrivastava
added a commit
to ViratSrivastava/astropy-sphinx-theme
that referenced
this pull request
Apr 3, 2023
change made as per issues raised by #705 StingraySoftware/stingray#705 #707 from StingraySoftware/stingray#707 Now documentation will show the stingray log. I was unable to add the stingray logo to the statics, hence replaced the image source with links from documentation website of stingray
Member
|
Thanks @devanshshukla99 ! |
matteobachetti
approved these changes
Apr 13, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As highlighted in #705, the documentation contains astropy's logo at the top left and as the favicon. This PR replaces those with the stingray's logo, fixes #705
The favicon can be replaced easily by overriding
html_faviconinconf.py, unfortunately, the same is not true for the logo in the top left, since it's hard coded intoastropy_sphinx_themeat https://github.com/astropy/astropy-sphinx-theme/blob/main/astropy_sphinx_theme/bootstrap-astropy/static/bootstrap-astropy.css?plain=1#L253-L255The current implementation works by overriding the css propery using
custom.cssand adding the32x32stingray's logo in base64 form.Rendered docs: