Update als method to use sparse matrix construction #725
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Reduces memory usage for large lightcurves by improving the matrix construction.
Codecov Report
@@ Coverage Diff @@
## main #725 +/- ##
=======================================
Coverage 97.16% 97.16%
=======================================
Files 42 42
Lines 7869 7872 +3
=======================================
+ Hits 7646 7649 +3
Misses 223 223
📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
matteobachetti
approved these changes
May 9, 2023
Member
matteobachetti
left a comment
matteobachetti
left a comment
There was a problem hiding this comment.
@shriharshtendulkar thanks a lot! I added a changelog and fixed the formatting, the PR is ready for merging.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Reduces memory usage for large lightcurves by improving the matrix construction.
Addresses issue #724