Eliminate deprecated format_ keyword from read and write methods #729
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…f EventList, Lightcurve, and everywhere else
Codecov Report
@@ Coverage Diff @@
## main #729 +/- ##
==========================================
- Coverage 97.16% 97.15% -0.01%
==========================================
Files 42 42
Lines 7872 7852 -20
==========================================
- Hits 7649 7629 -20
Misses 223 223
📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
dhuppenkothen
approved these changes
May 18, 2023
Member
dhuppenkothen
left a comment
dhuppenkothen
left a comment
There was a problem hiding this comment.
👍 LGTM! We should make a note somewhere when we release a new version (in the version notes?) that this is a breaking change?
Mark modification as breaking
Member
Author
|
@dhuppenkothen this name change should be sufficient. Towncrier will take care of it. |
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.