Skip to content

Conversation

@matteobachetti
Copy link
Member

@matteobachetti matteobachetti commented Apr 23, 2024

This is a quick fix to #821

Resolve #821

@codecov
Copy link

codecov bot commented Apr 23, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 96.50%. Comparing base (379ed3a) to head (16861d1).

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #822   +/-   ##
=======================================
  Coverage   96.49%   96.50%           
=======================================
  Files          45       45           
  Lines        9138     9149   +11     
=======================================
+ Hits         8818     8829   +11     
  Misses        320      320           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Collaborator

@mgullik mgullik left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @matteobachetti,

my only comment would be to expand the example in the docstring of analyze_segments showing what is the results of the function when there is at least one segment that results in a NaN

@matteobachetti matteobachetti added this pull request to the merge queue May 7, 2024
Merged via the queue into main with commit ca74d3c May 7, 2024
@matteobachetti matteobachetti deleted the fix_analyze_segments branch May 7, 2024 09:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

analyze_segments fails when some interval gives invalid data

3 participants