feat: Add Basic CRUD for Ratings#11
Merged
Merged
Conversation
added 8 commits
April 9, 2026 16:16
It uses mapstruct
Add order repository as well. It needed, because both classes are closely related.
|
Note Reviews pausedIt looks like this branch is under active development. To avoid overwhelming you with review comments due to an influx of new commits, CodeRabbit has automatically paused this review. You can configure this behavior by changing the Use the following commands to manage reviews:
Use the checkboxes below for quick actions:
📝 WalkthroughWalkthroughAdds new Order/Payment/Driver/Rating features: controllers, services, MapStruct mappers, DTOs, repositories; validation and role-based access on endpoints; test utilities plus extensive unit and integration tests; updates to Role/UserService authority handling, seed data, test properties, and global exception mappings. Changes
Sequence Diagram(s)sequenceDiagram
participant Client as Client
participant Controller as RatingController
participant Service as RatingService
participant OrderRepo as OrderRepository
participant RatingRepo as RatingRepository
participant RatingMapper as RatingMapper
participant DB as Database
Client->>Controller: POST /api/ratings (RatingRequestDTO)
Controller->>Service: createRating(request)
Service->>OrderRepo: findById(request.orderId)
OrderRepo->>DB: SELECT order by id
DB-->>OrderRepo: order row / empty
alt order found
OrderRepo-->>Service: Optional<OrderEntity>
Service->>RatingMapper: toEntity(request)
RatingMapper-->>Service: RatingEntity
Service->>RatingRepo: save(ratingEntity with order)
RatingRepo->>DB: INSERT rating
DB-->>RatingRepo: saved rating row
RatingRepo-->>Service: saved RatingEntity
Service->>RatingMapper: toDTO(saved RatingEntity)
RatingMapper-->>Service: RatingResponseDTO
Service-->>Controller: Optional<RatingResponseDTO>
Controller-->>Client: 201 Created + body
else order missing
OrderRepo-->>Service: Optional.empty
Service-->>Controller: Optional.empty
Controller-->>Client: 400 Bad Request
end
Estimated code review effort🎯 4 (Complex) | ⏱️ ~45 minutes Possibly related PRs
Poem
🚥 Pre-merge checks | ✅ 1 | ❌ 2❌ Failed checks (2 warnings)
✅ Passed checks (1 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
There was a problem hiding this comment.
Actionable comments posted: 1
🧹 Nitpick comments (4)
backend/src/main/java/com/angel/autonow/rating/RatingController.java (1)
19-23: Consider returning404whenorderIddoes not exist on create.For
POST /api/ratings, mapping missing related order to400blurs client input errors vs missing server resource. Returning404 Not Foundimproves API semantics.♻️ Suggested adjustment
`@PostMapping` public ResponseEntity<RatingResponseDTO> createRating(`@Valid` `@RequestBody` RatingRequestDTO request) { return ratingService.createRating(request) .map(rating -> ResponseEntity.status(HttpStatus.CREATED).body(rating)) - .orElse(ResponseEntity.badRequest().build()); + .orElse(ResponseEntity.notFound().build()); }🤖 Prompt for AI Agents
Verify each finding against the current code and only fix it if needed. In `@backend/src/main/java/com/angel/autonow/rating/RatingController.java` around lines 19 - 23, The createRating controller currently maps any absent result from ratingService.createRating(request) to 400, which hides "order not found" cases; update the service (ratingService.createRating) to return a distinct outcome for missing related order (e.g., Optional.empty() vs a specific error enum/exception) or throw a dedicated NotFound exception when the provided orderId doesn't exist, and change the controller method createRating in RatingController to return ResponseEntity.status(HttpStatus.NOT_FOUND) when the service indicates the order is missing while still returning 400 for other client validation errors and 201 for success (keep using RatingRequestDTO and RatingResponseDTO types).backend/src/test/java/com/angel/autonow/data/TestData.java (1)
17-23: Make test user email configurable to avoid data collisions.Using a single hardcoded email can fail tests that persist more than one user in the same DB state. Consider accepting an email parameter (or generating one) in the factory.
♻️ Suggested adjustment
+import java.util.UUID; @@ - public static UserEntity createUserEntity() { + public static UserEntity createUserEntity() { + return createUserEntity("test+" + UUID.randomUUID() + "@example.com"); + } + + public static UserEntity createUserEntity(String email) { return UserEntity.builder() - .email("test@example.com") + .email(email) .password("encodedPassword") .authorities(Set.of("ROLE_USER")) .build(); }🤖 Prompt for AI Agents
Verify each finding against the current code and only fix it if needed. In `@backend/src/test/java/com/angel/autonow/data/TestData.java` around lines 17 - 23, The factory method createUserEntity currently returns a UserEntity with a hardcoded email leading to test collisions; change the method signature to accept a String email parameter (e.g., createUserEntity(String email)) and use that value in UserEntity.builder().email(...), or add an overloaded createUserEntity() that generates a unique email (e.g., using UUID) and delegates to createUserEntity(email); update usages in tests to pass or accept the generated email accordingly so each test can supply or receive a unique address.backend/src/main/java/com/angel/autonow/rating/RatingService.java (1)
19-31: Consider handling duplicate rating scenario.The
RatingEntityhas a unique constraint onorder_id(fromRatingEntity.java:37-38). If a rating already exists for an order,save()will throw aDataIntegrityViolationException. Consider either:
- Checking for existing rating before save and returning an appropriate response
- Catching the exception and converting it to a meaningful error
Also, consider adding
@Transactionalto ensure atomicity of the read-then-write operation.♻️ Suggested improvement
+import org.springframework.transaction.annotation.Transactional; + `@Service` `@RequiredArgsConstructor` public class RatingService { private final RatingRepository ratingRepository; private final RatingMapper ratingMapper; private final OrderRepository orderRepository; + `@Transactional` public Optional<RatingResponseDTO> createRating(RatingRequestDTO request) { Optional<OrderEntity> order = orderRepository.findById(request.orderId()); if (order.isEmpty()) { return Optional.empty(); } + + if (ratingRepository.findByOrderId(request.orderId()).isPresent()) { + return Optional.empty(); // Or throw a custom exception for duplicate rating + } RatingEntity rating = ratingMapper.toEntity(request);🤖 Prompt for AI Agents
Verify each finding against the current code and only fix it if needed. In `@backend/src/main/java/com/angel/autonow/rating/RatingService.java` around lines 19 - 31, createRating currently reads the order then saves a new RatingEntity which can violate the unique order_id constraint; before saving, check for an existing rating via ratingRepository (e.g., findByOrderId or findByOrder(order.get())) and return an appropriate Optional.empty() or a domain-specific error DTO, or wrap the save in a try/catch that converts DataIntegrityViolationException into a meaningful response; also annotate createRating (or the service class) with `@Transactional` to make the read-then-write atomic and use the ratingMapper, ratingRepository and orderRepository symbols when locating code to modify.backend/src/test/java/com/angel/autonow/rating/RatingControllerIT.java (1)
128-134: Consider returning 404 for "not found" scenarios.The test expects
200 OKwith an empty body when a rating is not found. From a REST API design perspective, returning404 Not Foundwould be more semantically correct for resource retrieval when the resource doesn't exist. This would require updating both the controller and these tests.🤖 Prompt for AI Agents
Verify each finding against the current code and only fix it if needed. In `@backend/src/test/java/com/angel/autonow/rating/RatingControllerIT.java` around lines 128 - 134, Update the controller to return 404 when a rating is not found and update the integration test accordingly: change the RatingController endpoint handler (the method handling GET /api/ratings/{id}, e.g., getRatingById) to return ResponseEntity.notFound() (or throw a ResponseStatusException with HttpStatus.NOT_FOUND) when the service (e.g., ratingService.findById or repository lookup) yields no result, and then modify the test RatingControllerIT.getRatingById_notFound_returnsOkEmpty to expect status().isNotFound() (and no body) instead of status().isOk(); ensure any helper/service methods used (ratingService.findById) are updated/mocked to reflect the not-found behavior.
🤖 Prompt for all review comments with AI agents
Verify each finding against the current code and only fix it if needed.
Inline comments:
In `@backend/src/main/java/com/angel/autonow/rating/RatingController.java`:
- Around line 25-33: Change the endpoints to return 404 when the rating is
missing instead of 200 with a null body: update getRatingById and
getRatingByOrderId to return ResponseEntity.notFound() (or use
ResponseEntity.of(Optional)) when ratingService.getRatingById(id) /
ratingService.getRatingByOrderId(orderId) is empty, and return
ResponseEntity.ok(...) when present; reference the methods getRatingById,
getRatingByOrderId and the calls to ratingService.getRatingById(...) and
ratingService.getRatingByOrderId(...) to locate the changes.
---
Nitpick comments:
In `@backend/src/main/java/com/angel/autonow/rating/RatingController.java`:
- Around line 19-23: The createRating controller currently maps any absent
result from ratingService.createRating(request) to 400, which hides "order not
found" cases; update the service (ratingService.createRating) to return a
distinct outcome for missing related order (e.g., Optional.empty() vs a specific
error enum/exception) or throw a dedicated NotFound exception when the provided
orderId doesn't exist, and change the controller method createRating in
RatingController to return ResponseEntity.status(HttpStatus.NOT_FOUND) when the
service indicates the order is missing while still returning 400 for other
client validation errors and 201 for success (keep using RatingRequestDTO and
RatingResponseDTO types).
In `@backend/src/main/java/com/angel/autonow/rating/RatingService.java`:
- Around line 19-31: createRating currently reads the order then saves a new
RatingEntity which can violate the unique order_id constraint; before saving,
check for an existing rating via ratingRepository (e.g., findByOrderId or
findByOrder(order.get())) and return an appropriate Optional.empty() or a
domain-specific error DTO, or wrap the save in a try/catch that converts
DataIntegrityViolationException into a meaningful response; also annotate
createRating (or the service class) with `@Transactional` to make the
read-then-write atomic and use the ratingMapper, ratingRepository and
orderRepository symbols when locating code to modify.
In `@backend/src/test/java/com/angel/autonow/data/TestData.java`:
- Around line 17-23: The factory method createUserEntity currently returns a
UserEntity with a hardcoded email leading to test collisions; change the method
signature to accept a String email parameter (e.g., createUserEntity(String
email)) and use that value in UserEntity.builder().email(...), or add an
overloaded createUserEntity() that generates a unique email (e.g., using UUID)
and delegates to createUserEntity(email); update usages in tests to pass or
accept the generated email accordingly so each test can supply or receive a
unique address.
In `@backend/src/test/java/com/angel/autonow/rating/RatingControllerIT.java`:
- Around line 128-134: Update the controller to return 404 when a rating is not
found and update the integration test accordingly: change the RatingController
endpoint handler (the method handling GET /api/ratings/{id}, e.g.,
getRatingById) to return ResponseEntity.notFound() (or throw a
ResponseStatusException with HttpStatus.NOT_FOUND) when the service (e.g.,
ratingService.findById or repository lookup) yields no result, and then modify
the test RatingControllerIT.getRatingById_notFound_returnsOkEmpty to expect
status().isNotFound() (and no body) instead of status().isOk(); ensure any
helper/service methods used (ratingService.findById) are updated/mocked to
reflect the not-found behavior.
🪄 Autofix (Beta)
Fix all unresolved CodeRabbit comments on this PR:
- Push a commit to this branch (recommended)
- Create a new PR with the fixes
ℹ️ Review info
⚙️ Run configuration
Configuration used: Path: .coderabbit.yaml
Review profile: CHILL
Plan: Pro
Run ID: 11d9043f-6c16-419a-908c-35bfbf2c79cf
📒 Files selected for processing (11)
backend/src/main/java/com/angel/autonow/order/OrderRepository.javabackend/src/main/java/com/angel/autonow/rating/RatingController.javabackend/src/main/java/com/angel/autonow/rating/RatingMapper.javabackend/src/main/java/com/angel/autonow/rating/RatingRepository.javabackend/src/main/java/com/angel/autonow/rating/RatingRequestDTO.javabackend/src/main/java/com/angel/autonow/rating/RatingResponseDTO.javabackend/src/main/java/com/angel/autonow/rating/RatingService.javabackend/src/test/java/com/angel/autonow/data/TestData.javabackend/src/test/java/com/angel/autonow/rating/RatingControllerIT.javabackend/src/test/java/com/angel/autonow/rating/RatingServiceTest.javabackend/src/test/resources/application-test.properties
added 3 commits
April 9, 2026 16:44
That should resolve the issue with ITs
There was a problem hiding this comment.
Actionable comments posted: 5
🧹 Nitpick comments (7)
backend/src/main/java/com/angel/autonow/payment/PaymentResponseDTO.java (1)
11-11: Consider usingBigDecimalfor monetary amounts instead ofDouble.
Doublecan introduce floating-point precision errors in financial calculations (e.g.,0.1 + 0.2 ≠ 0.3). For payment amounts,BigDecimalis the standard practice to ensure accurate representation and avoid rounding issues in display or downstream calculations.If the underlying
PaymentEntityalso usesDouble, this would need to be addressed there as well.🤖 Prompt for AI Agents
Verify each finding against the current code and only fix it if needed. In `@backend/src/main/java/com/angel/autonow/payment/PaymentResponseDTO.java` at line 11, PaymentResponseDTO currently declares the monetary field as Double (amount) which can cause precision errors; change the type of the amount field in PaymentResponseDTO to java.math.BigDecimal (and update any getters/setters, constructors, builder methods, and equals/hashCode that reference amount) and ensure JSON serialization/deserialization is handled (e.g., Jackson will map BigDecimal automatically or add appropriate annotations if custom formatting is needed); if PaymentEntity or other layers still use Double, update those corresponding fields and conversion logic to use BigDecimal as well to keep types consistent across mapping methods (e.g., any fromEntity/toDto converters).backend/src/main/java/com/angel/autonow/exception/GlobalControllerExceptionHandler.java (1)
103-107: Inconsistent logging:NoResourceFoundExceptionhandler omits the log statement.All other exception handlers in this class log the exception before returning the
ProblemDetail. This handler is missing thelog.warn()call, which creates an inconsistency. If this is intentional (e.g., to reduce noise from 404s), consider adding a brief comment explaining why.♻️ Suggested fix for consistency
`@ResponseStatus`(HttpStatus.NOT_FOUND) `@ExceptionHandler`(NoResourceFoundException.class) public ProblemDetail handleNoResourceFoundException(NoResourceFoundException e) { + log.warn(e.getMessage(), HttpStatus.NOT_FOUND, e); return handle(e, HttpStatus.NOT_FOUND); }🤖 Prompt for AI Agents
Verify each finding against the current code and only fix it if needed. In `@backend/src/main/java/com/angel/autonow/exception/GlobalControllerExceptionHandler.java` around lines 103 - 107, The NoResourceFoundException handler handleNoResourceFoundException currently returns a ProblemDetail without logging, causing inconsistency with other handlers; update handleNoResourceFoundException to call log.warn(...) (including the exception and a brief message) before returning handle(e, HttpStatus.NOT_FOUND) to match the pattern used by the other exception handlers, or if 404 noise suppression is intentional, add a short explanatory comment above the method mentioning that logging is intentionally omitted.backend/src/main/java/com/angel/autonow/payment/PaymentRequestDTO.java (1)
11-13: Same concern: considerBigDecimalfor monetary amounts.Consistent with the note on
PaymentResponseDTO, usingBigDecimalwould prevent floating-point precision issues when clients submit payment amounts.🤖 Prompt for AI Agents
Verify each finding against the current code and only fix it if needed. In `@backend/src/main/java/com/angel/autonow/payment/PaymentRequestDTO.java` around lines 11 - 13, Change the amount field in PaymentRequestDTO from Double to BigDecimal to avoid floating‑point precision issues: update the declaration in class PaymentRequestDTO (field "amount") to use java.math.BigDecimal, adjust imports, and ensure validation annotations are compatible (keep `@NotNull` and replace or keep `@Positive/`@DecimalMin as appropriate for BigDecimal); also update any constructors, getters/setters, and JSON (de)serialization code that consume or produce this field so callers and Jackson map BigDecimal correctly.backend/src/test/java/com/angel/autonow/driver/DriverServiceTest.java (1)
30-56: Consider verifying mock interactions.The test validates the return value but doesn't verify that the mapper and repository were called with expected arguments. Adding
verify()calls would strengthen the test.♻️ Suggested improvement
assertTrue(result.isPresent()); assertEquals(1L, result.get().id()); assertEquals("Michael", result.get().firstName()); + + verify(driverMapper).toEntity(request); + verify(driverRepository).save(entity); + verify(driverMapper).toDTO(saved); }🤖 Prompt for AI Agents
Verify each finding against the current code and only fix it if needed. In `@backend/src/test/java/com/angel/autonow/driver/DriverServiceTest.java` around lines 30 - 56, The test createDriver_returnDriverResponse in DriverServiceTest should also assert mock interactions: after calling driverService.createDriver(request) add verify(driverMapper).toEntity(request), verify(driverRepository).save(entity), and verify(driverMapper).toDTO(saved) to ensure the mapper and repository were invoked with the expected arguments; optionally add verifyNoMoreInteractions(driverMapper, driverRepository) to catch unexpected calls.backend/src/main/java/com/angel/autonow/order/OrderController.java (1)
24-30: Consider distinguishing error types in createOrder response.Returning
400 Bad RequestwhencreateOrderreturns empty is ambiguous—it could indicate the referenced user/driver/vehicle doesn't exist, not just a validation error. Consider throwing a specific exception (e.g.,EntityNotFoundException) that maps to404for missing references, or422 Unprocessable Entityfor business rule violations.🤖 Prompt for AI Agents
Verify each finding against the current code and only fix it if needed. In `@backend/src/main/java/com/angel/autonow/order/OrderController.java` around lines 24 - 30, The controller currently treats any empty Optional from orderService.createOrder(request) as a 400; instead have the service surface specific failures (e.g., throw EntityNotFoundException when referenced User/Driver/Vehicle is missing, or a BusinessRuleException for domain violations) and update OrderController.createOrder to let those exceptions propagate (or catch and rethrow as ResponseStatusException), and add global handlers (or `@ExceptionHandler` methods / a `@ControllerAdvice`) that map EntityNotFoundException -> 404 NOT_FOUND and BusinessRuleException -> 422 UNPROCESSABLE_ENTITY so callers get precise status codes rather than a generic 400; key symbols: OrderController.createOrder, orderService.createOrder, EntityNotFoundException, BusinessRuleException, and your global exception handler class or `@ExceptionHandler` methods.backend/src/main/java/com/angel/autonow/order/OrderRequestDTO.java (1)
23-36: Consider adding range validation for coordinates.Latitude must be between -90 and 90, longitude between -180 and 180. Invalid coordinates could cause issues with mapping services or distance calculations.
♻️ Suggested improvement
+import jakarta.validation.constraints.DecimalMax; +import jakarta.validation.constraints.DecimalMin; + `@NotNull`(message = "Pickup latitude is required") + `@DecimalMin`(value = "-90.0", message = "Latitude must be >= -90") + `@DecimalMax`(value = "90.0", message = "Latitude must be <= 90") Double pickupLatitude, `@NotNull`(message = "Pickup longitude is required") + `@DecimalMin`(value = "-180.0", message = "Longitude must be >= -180") + `@DecimalMax`(value = "180.0", message = "Longitude must be <= 180") Double pickupLongitude,Apply similar constraints to
dropoffLatitudeanddropoffLongitude.🤖 Prompt for AI Agents
Verify each finding against the current code and only fix it if needed. In `@backend/src/main/java/com/angel/autonow/order/OrderRequestDTO.java` around lines 23 - 36, Add range validation to the coordinate fields in OrderRequestDTO: annotate pickupLatitude and dropoffLatitude with `@DecimalMin`(value = "-90") and `@DecimalMax`(value = "90"), and annotate pickupLongitude and dropoffLongitude with `@DecimalMin`(value = "-180") and `@DecimalMax`(value = "180"); ensure you import javax.validation.constraints.DecimalMin and DecimalMax (or the project's equivalent) so invalid lat/lon outside the allowed ranges are rejected during validation.backend/src/test/java/com/angel/autonow/order/OrderServiceTest.java (1)
83-112: Add a negative-path test for invaliddriverId/vehicleId.Please add a case where IDs are provided but repositories return empty, then assert
createOrderfails (or behaves as explicitly intended). This will lock down the edge-case contract.🤖 Prompt for AI Agents
Verify each finding against the current code and only fix it if needed. In `@backend/src/test/java/com/angel/autonow/order/OrderServiceTest.java` around lines 83 - 112, Add negative-path tests in OrderServiceTest for missing driver/vehicle: create new test(s) (e.g., createOrder_withMissingDriver_returnsEmpty and createOrder_withMissingVehicle_returnsEmpty) that build an OrderRequestDTO like the existing createOrder_withDriverAndVehicle, mock userRepository.findById(1L) to return the user but mock driverRepository.findById(2L) (or vehicleRepository.findById(3L)) to return Optional.empty(), call orderService.createOrder(request) and assert the result is empty (result.isPresent() == false); use the same test fixtures (OrderRequestDTO, UserEntity, OrderEntity mapping mocks) and the existing repository/matcher symbols (driverRepository, vehicleRepository, orderMapper, orderRepository) to locate and implement the tests.
🤖 Prompt for all review comments with AI agents
Verify each finding against the current code and only fix it if needed.
Inline comments:
In `@backend/src/main/java/com/angel/autonow/driver/DriverController.java`:
- Around line 34-41: The controller methods getDriverById and
getDriverByLicenseNumber currently return null when the Optional from
driverService (driverService.getDriverById /
driverService.getDriverByLicenseNumber) is empty; change these methods to return
a 404 instead of null by converting the return type to
ResponseEntity<DriverResponseDTO> (or throw new
ResponseStatusException(HttpStatus.NOT_FOUND)) and return
ResponseEntity.ok(body) when present or ResponseEntity.notFound().build() (or
throw the NOT_FOUND exception) when the Optional is empty so missing drivers
produce HTTP 404.
In `@backend/src/main/java/com/angel/autonow/order/OrderController.java`:
- Around line 32-36: The getOrderById controller currently returns null when
orderService.getOrderById(id) is empty; change OrderController.getOrderById to
return a 404 instead of null by detecting the Optional absence and either
throwing a ResponseStatusException(HttpStatus.NOT_FOUND, "...") or returning a
ResponseEntity.notFound().build(); locate the getOrderById method and replace
the .orElse(null) return with one of these patterns so missing orders yield HTTP
404.
In `@backend/src/main/java/com/angel/autonow/order/OrderService.java`:
- Around line 33-39: The code currently ignores unresolved driverId/vehicleId by
using findById(...).ifPresent(...), so if the client supplied an ID that doesn't
exist the order is created silently; change this to fail fast: when
request.driverId() != null use
driverRepository.findById(request.driverId()).orElseThrow(...) and set the
driver on the order (e.g., order.setDriver(foundDriver)), and similarly when
request.vehicleId() != null use
vehicleRepository.findById(request.vehicleId()).orElseThrow(...) and set the
vehicle; choose an appropriate exception type (e.g., IllegalArgumentException,
EntityNotFoundException, or your API BadRequest/NotFound exception) so the
controller returns an error instead of dropping the unresolved reference.
In `@backend/src/main/java/com/angel/autonow/payment/PaymentController.java`:
- Around line 32-42: The controller currently returns null for missing payments
in PaymentController.getPaymentById and getPaymentByOrderId which yields 200;
change these methods to return ResponseEntity<PaymentResponseDTO> and map the
Optional results from paymentService.getPaymentById(id) and
paymentService.getPaymentByOrderId(orderId) to ResponseEntity.ok(...) when
present or ResponseEntity.notFound().build() when empty (or use
ResponseEntity.of(Optional)). Update method signatures and imports accordingly
so missing resources produce 404 Not Found.
In `@backend/src/main/java/com/angel/autonow/payment/PaymentService.java`:
- Around line 19-31: The createPayment method in PaymentService must check for
an existing payment and run in a transaction: before mapping/saving, use
paymentRepository (e.g. existsByOrderId or findByOrder) to detect an existing
PaymentEntity for the given order and return an appropriate result (or throw a
DuplicatePaymentException) instead of relying on the DB unique constraint on
PaymentEntity.order; annotate the method (or the PaymentService class) with
`@Transactional` to ensure the find and save run in one transactional boundary,
and add a defensive catch for DataIntegrityViolationException around
paymentRepository.save(...) to translate DB errors into a clear
application-level error.
---
Nitpick comments:
In
`@backend/src/main/java/com/angel/autonow/exception/GlobalControllerExceptionHandler.java`:
- Around line 103-107: The NoResourceFoundException handler
handleNoResourceFoundException currently returns a ProblemDetail without
logging, causing inconsistency with other handlers; update
handleNoResourceFoundException to call log.warn(...) (including the exception
and a brief message) before returning handle(e, HttpStatus.NOT_FOUND) to match
the pattern used by the other exception handlers, or if 404 noise suppression is
intentional, add a short explanatory comment above the method mentioning that
logging is intentionally omitted.
In `@backend/src/main/java/com/angel/autonow/order/OrderController.java`:
- Around line 24-30: The controller currently treats any empty Optional from
orderService.createOrder(request) as a 400; instead have the service surface
specific failures (e.g., throw EntityNotFoundException when referenced
User/Driver/Vehicle is missing, or a BusinessRuleException for domain
violations) and update OrderController.createOrder to let those exceptions
propagate (or catch and rethrow as ResponseStatusException), and add global
handlers (or `@ExceptionHandler` methods / a `@ControllerAdvice`) that map
EntityNotFoundException -> 404 NOT_FOUND and BusinessRuleException -> 422
UNPROCESSABLE_ENTITY so callers get precise status codes rather than a generic
400; key symbols: OrderController.createOrder, orderService.createOrder,
EntityNotFoundException, BusinessRuleException, and your global exception
handler class or `@ExceptionHandler` methods.
In `@backend/src/main/java/com/angel/autonow/order/OrderRequestDTO.java`:
- Around line 23-36: Add range validation to the coordinate fields in
OrderRequestDTO: annotate pickupLatitude and dropoffLatitude with
`@DecimalMin`(value = "-90") and `@DecimalMax`(value = "90"), and annotate
pickupLongitude and dropoffLongitude with `@DecimalMin`(value = "-180") and
`@DecimalMax`(value = "180"); ensure you import
javax.validation.constraints.DecimalMin and DecimalMax (or the project's
equivalent) so invalid lat/lon outside the allowed ranges are rejected during
validation.
In `@backend/src/main/java/com/angel/autonow/payment/PaymentRequestDTO.java`:
- Around line 11-13: Change the amount field in PaymentRequestDTO from Double to
BigDecimal to avoid floating‑point precision issues: update the declaration in
class PaymentRequestDTO (field "amount") to use java.math.BigDecimal, adjust
imports, and ensure validation annotations are compatible (keep `@NotNull` and
replace or keep `@Positive/`@DecimalMin as appropriate for BigDecimal); also
update any constructors, getters/setters, and JSON (de)serialization code that
consume or produce this field so callers and Jackson map BigDecimal correctly.
In `@backend/src/main/java/com/angel/autonow/payment/PaymentResponseDTO.java`:
- Line 11: PaymentResponseDTO currently declares the monetary field as Double
(amount) which can cause precision errors; change the type of the amount field
in PaymentResponseDTO to java.math.BigDecimal (and update any getters/setters,
constructors, builder methods, and equals/hashCode that reference amount) and
ensure JSON serialization/deserialization is handled (e.g., Jackson will map
BigDecimal automatically or add appropriate annotations if custom formatting is
needed); if PaymentEntity or other layers still use Double, update those
corresponding fields and conversion logic to use BigDecimal as well to keep
types consistent across mapping methods (e.g., any fromEntity/toDto converters).
In `@backend/src/test/java/com/angel/autonow/driver/DriverServiceTest.java`:
- Around line 30-56: The test createDriver_returnDriverResponse in
DriverServiceTest should also assert mock interactions: after calling
driverService.createDriver(request) add verify(driverMapper).toEntity(request),
verify(driverRepository).save(entity), and verify(driverMapper).toDTO(saved) to
ensure the mapper and repository were invoked with the expected arguments;
optionally add verifyNoMoreInteractions(driverMapper, driverRepository) to catch
unexpected calls.
In `@backend/src/test/java/com/angel/autonow/order/OrderServiceTest.java`:
- Around line 83-112: Add negative-path tests in OrderServiceTest for missing
driver/vehicle: create new test(s) (e.g.,
createOrder_withMissingDriver_returnsEmpty and
createOrder_withMissingVehicle_returnsEmpty) that build an OrderRequestDTO like
the existing createOrder_withDriverAndVehicle, mock userRepository.findById(1L)
to return the user but mock driverRepository.findById(2L) (or
vehicleRepository.findById(3L)) to return Optional.empty(), call
orderService.createOrder(request) and assert the result is empty
(result.isPresent() == false); use the same test fixtures (OrderRequestDTO,
UserEntity, OrderEntity mapping mocks) and the existing repository/matcher
symbols (driverRepository, vehicleRepository, orderMapper, orderRepository) to
locate and implement the tests.
🪄 Autofix (Beta)
Fix all unresolved CodeRabbit comments on this PR:
- Push a commit to this branch (recommended)
- Create a new PR with the fixes
ℹ️ Review info
⚙️ Run configuration
Configuration used: Path: .coderabbit.yaml
Review profile: CHILL
Plan: Pro
Run ID: 15bc7c9c-956b-46f7-a005-f3a730c97d4b
📒 Files selected for processing (29)
backend/src/main/java/com/angel/autonow/driver/DriverController.javabackend/src/main/java/com/angel/autonow/driver/DriverMapper.javabackend/src/main/java/com/angel/autonow/driver/DriverRepository.javabackend/src/main/java/com/angel/autonow/driver/DriverRequestDTO.javabackend/src/main/java/com/angel/autonow/driver/DriverResponseDTO.javabackend/src/main/java/com/angel/autonow/driver/DriverService.javabackend/src/main/java/com/angel/autonow/exception/GlobalControllerExceptionHandler.javabackend/src/main/java/com/angel/autonow/order/OrderController.javabackend/src/main/java/com/angel/autonow/order/OrderMapper.javabackend/src/main/java/com/angel/autonow/order/OrderRepository.javabackend/src/main/java/com/angel/autonow/order/OrderRequestDTO.javabackend/src/main/java/com/angel/autonow/order/OrderResponseDTO.javabackend/src/main/java/com/angel/autonow/order/OrderService.javabackend/src/main/java/com/angel/autonow/payment/PaymentController.javabackend/src/main/java/com/angel/autonow/payment/PaymentMapper.javabackend/src/main/java/com/angel/autonow/payment/PaymentRepository.javabackend/src/main/java/com/angel/autonow/payment/PaymentRequestDTO.javabackend/src/main/java/com/angel/autonow/payment/PaymentResponseDTO.javabackend/src/main/java/com/angel/autonow/payment/PaymentService.javabackend/src/main/java/com/angel/autonow/rating/RatingResponseDTO.javabackend/src/test/java/com/angel/autonow/data/TestData.javabackend/src/test/java/com/angel/autonow/driver/DriverControllerIT.javabackend/src/test/java/com/angel/autonow/driver/DriverServiceTest.javabackend/src/test/java/com/angel/autonow/order/OrderControllerIT.javabackend/src/test/java/com/angel/autonow/order/OrderServiceTest.javabackend/src/test/java/com/angel/autonow/payment/PaymentControllerIT.javabackend/src/test/java/com/angel/autonow/payment/PaymentServiceTest.javabackend/src/test/java/com/angel/autonow/rating/RatingControllerIT.javabackend/src/test/java/com/angel/autonow/rating/RatingServiceTest.java
✅ Files skipped from review due to trivial changes (1)
- backend/src/main/java/com/angel/autonow/rating/RatingResponseDTO.java
🚧 Files skipped from review as they are similar to previous changes (4)
- backend/src/main/java/com/angel/autonow/order/OrderRepository.java
- backend/src/test/java/com/angel/autonow/rating/RatingControllerIT.java
- backend/src/test/java/com/angel/autonow/rating/RatingServiceTest.java
- backend/src/test/java/com/angel/autonow/data/TestData.java
This was referenced Apr 10, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary by CodeRabbit