Skip to content

Conversation

@71
Copy link

@71 71 commented Feb 23, 2025

Thank you @jwhitaker-gridcog for the pointer!

@Strackeror
Copy link
Owner

Strackeror commented Feb 23, 2025

I'll be honest, i'm not sure I like the symlink way of doing this, anymore. I've since had to do builds on windows, and git symlinks just... don't work at all on windows, not unless you change particular git settings and have admin access to your machine.

@71
Copy link
Author

71 commented Feb 23, 2025

Ah, gotcha, good point. What do you suggest instead? I thought we could reuse the build scripts to automatically copy files. And thinking about it, the README should probably be modified to refer to Helix instead of being a copy of the original.

@Strackeror
Copy link
Owner

At this point I'm wondering if there's even a need for the deduplication at all. The README probably needs to be different, (though what to put in it I'm not sure).

For the icon, I'm thinking of hue shifting it, so it would be a bit different and slightly match the helix color scheme.
dance

Which only leaves the LICENSE file, and I'm not sure it's worth having the abstraction for one duplicate file that's unlikely to ever change. If we really need to, we just copy it in the package.build.ts file and leave it at that I think

@71 71 mentioned this pull request Mar 8, 2025
@71
Copy link
Author

71 commented Mar 8, 2025

Closing in favor of #4 as I agree with your feedback.

@71 71 closed this Mar 8, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants