Merged
Conversation
Collaborator
|
gonna leave this open as a reminder to do this eventually |
Collaborator
|
The bug is now fixed, but the changes are not yet published. This no longer needs to serve as a reminder to fix the bug. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Note that the core physics bug behind this map not working is still present (Colliding with a sphere and another object at the same time - even if the sphere is non-collide - will cause an error in Trey-MinimumDifference)
This fix needs to happen regardless, since the current version of the map may actually make you blind, but this won't fix the physics bug. We could technically quick-patch the bug and remove the meshes from the bushes (mesh-less fix available in
13553743491), but I think it would be better to have the core issue fixed instead of a bandaid fix.