fix: skip framework download when already at latest version#5
Merged
Conversation
Add semver comparison in update-framework to match the pattern already used by update-cli in self_update.rs. Without this, every `devtrail update` re-downloads and overwrites all 65 framework files even when the installed version matches the latest release. Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
|
|
3 tasks
montfort
added a commit
that referenced
this pull request
May 2, 2026
#68) First Charter-driven release. Originating Charter: sentinel/docs/charters/01-format-v4-atomic-charter-closure-pattern.md Originating decision: AIDEC-2026-05-02-001 (Sentinel), which formalized the canon gap discovered via PLAN-07: "update Plan-doc post-merge if AILOG documented divergencias" was mentioned but had no systematic trigger, leading to drift remediation lagging by days. Format v4 changes (charter-template.md EN + i18n/es): - Step 1 of `## Charter Closure` becomes "Atomic update (format v4)" — if drift was reported by Tasks #7, edit `## Files to modify` and/or add `## Closing notes` in the same commit/PR. No housekeeping deferral. - New top-level `## Closing notes` section with template structure and references to PLAN-05 / PLAN-07 of Sentinel as historical examples. - Convention #5 in the comment block rewritten for atomic-update at Tasks #7 time, citing PLAN-07 + AIDEC-2026-05-02-001. - Trigger placeholder broadened: "[1-line: what observable signal...]" → "[1-line: what concrete signal — observable event, declared decision, metric threshold, or infrastructure milestone — justifies executing this Charter now]". Surfaced during the originating Charter review (Charters from AIDECs/ADRs have declarative triggers). - §Risks placeholder gains guidance on mitigation completeness (4 properties: trigger, action, failure case, follow-up location). Surfaced during R4 review of the originating Charter. Promote 4 Propuesta files to public git history (governance hygiene): - que-es-un-charter.md (4 broken refs from shipped docs since fw-4.4.0) - devtrail-cli-roadmap.md (5 broken refs) - devtrail-thesis-validation.md (3 broken refs) - devtrail-design-principles.md (1 broken ref) The other 3 Propuesta/ files (devtrail-charter-telemetry.md, devtrail-cloud-proposal.md, devtrail-studio-vision.md) remain local-only because no shipped doc references them. Editorial-only release, no schema changes, no breaking changes. Adopters pick up format v4 via `devtrail update-framework`. Co-authored-by: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
update-frameworkbefore downloading, matching the pattern already used byupdate-cliinself_update.rsdevtrail updatere-downloads and overwrites all 65 framework files even when the installed version matches the latest releaseTest plan
cargo build— compiles cleancargo test— 25 tests passingchecksums.version("fw-2.1.0") →strip_tag_prefix("2.1.0") → semver parse → correct comparison🤖 Generated with Claude Code