Uninstall fixes

[stephywells]

Fixes https://github.com/Strategy11/awpcp/issues/3165

Without the unit tests in #56

Summary by CodeRabbit

• Chores

  • Updated dependencies in the GitHub workflow for improved reliability and security.

• New Features

  • Enhanced security for the uninstall process of the AWP Classifieds Plugin by adding nonce verification and authorization checks.

• Refactor

  • Updated the admin panel's uninstall functionality for the AWP Classifieds Plugin, including URL and text modifications for clarity and usability.

[coderabbitai]

Walkthrough

The recent updates involve enhancing the security and usability of a PHP project. Specifically, actions for automated testing have been upgraded, security measures through nonce verification and authorization checks have been added before performing sensitive operations, and user interface adjustments have been made to the admin panel related to a plugin's uninstallation process. These changes collectively aim to improve the project's reliability and user experience.

Changes

File Path	Change Summary
.github/workflows/phpunit.yml	Updated actions/checkout to v3.5.3 and shivammathur/setup-php to 2.25.5.
admin/class-uninstall-admin-page.php	Added nonce verification and authorization check.
admin/templates/.../admin-panel-uninstall.tpl.php	Updated URL and text for AWP Classifieds Plugin uninstallation.

🐰✨
In the garden of code, where changes bloom,
A rabbit hops, away from doom.
With every leap, security tight,
And usability in the moonlight bright.
🌟📜 To celebrate, a poem I write.
🚀 To the future, we take flight!

Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

Share

• X
• Mastodon
• Reddit
• LinkedIn

---

Tips

Chat

There are 3 ways to chat with CodeRabbit:

• Review comments: Directly reply to a review comment made by CodeRabbit. Example:
  • I pushed a fix in commit <commit_id>.
  • Generate unit-tests for this file.
  • Open a follow-up GitHub issue for this discussion.
• Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
  • @coderabbitai generate unit tests for this file.
  • @coderabbitai modularize this function.
• PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
  • @coderabbitai generate interesting stats about this repository and render them as a table.
  • @coderabbitai show all the console.log statements in this repository.
  • @coderabbitai read src/utils.ts and generate unit tests.
  • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (invoked as PR comments)

• @coderabbitai pause to pause the reviews on a PR.
• @coderabbitai resume to resume the paused reviews.
• @coderabbitai review to trigger a review. This is useful when automatic reviews are disabled for the repository.
• @coderabbitai resolve resolve all the CodeRabbit review comments.
• @coderabbitai help to get help.

Additionally, you can add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.

CodeRabbit Configration File (.coderabbit.yaml)

• You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
• The JSON schema for the configuration file is available here.
• If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/coderabbit-overrides.v2.json

CodeRabbit Discord Community

Join our Discord Community to get help, request features, and share feedback.

[coderabbitai]

Review Status

Actionable comments generated: 0

Configuration used: CodeRabbit UI

Commits

Files that changed from the base of the PR and between 7a9631c and 0f2319a.

Files selected for processing (3)

• .github/workflows/phpunit.yml (1 hunks)
• admin/class-uninstall-admin-page.php (1 hunks)
• admin/templates/admin-panel-uninstall.tpl.php (1 hunks)

Additional comments: 4

admin/class-uninstall-admin-page.php (1)

• 49-53: The addition of nonce verification and authorization check before proceeding with the uninstallation logic is a crucial security enhancement. Ensure that the nonce is created with the action name 'awpcp-uninstall' elsewhere in the code and that awpcp_current_user_is_admin accurately checks for admin privileges.

.github/workflows/phpunit.yml (1)

• 23-26: Updating the versions of actions/checkout to v3.5.3 and shivammathur/setup-php to 2.25.5 is a good practice to ensure compatibility and access to new features. Please verify that these versions are compatible with the rest of the workflow's configuration and requirements.

admin/templates/admin-panel-uninstall.tpl.php (2)

• 27-29: The update to create a nonce URL for the uninstallation process enhances security and user experience. Ensure that the nonce action name 'awpcp-uninstall' matches the one used in the verification process.
• 37-39: Updating the text and URL for the final step in the uninstallation process is a good improvement for clarity and user guidance. Ensure that the text is clear and guides the user appropriately through the process.