Skip to content

Fix 351#496

Merged
sorinmarta merged 2 commits into
masterfrom
fix-351
Apr 14, 2026
Merged

Fix 351#496
sorinmarta merged 2 commits into
masterfrom
fix-351

Conversation

@sorinmarta
Copy link
Copy Markdown
Contributor

No description provided.

@sorinmarta sorinmarta requested a review from Copilot April 14, 2026 06:44
@sorinmarta sorinmarta added the run analysis Runs phpcs and phpunit label Apr 14, 2026
Copy link
Copy Markdown

@coderabbitai coderabbitai Bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actionable comments posted: 1

🤖 Prompt for all review comments with AI agents
Verify each finding against the current code and only fix it if needed.

Inline comments:
In `@includes/fields/class-fieldtypes-social.php`:
- Line 121: Replace the ternary/empty pattern that discards a valid "0" value by
using null coalescing: locate the esc_attr call that currently wraps ! empty(
$value['social-text'] ) ? $value['social-text'] : '' (in
class-fieldtypes-social.php) and change it to use $value['social-text'] ?? '' so
that '0' is preserved and matches repo style.
🪄 Autofix (Beta)

Fix all unresolved CodeRabbit comments on this PR:

  • Push a commit to this branch (recommended)
  • Create a new PR with the fixes

ℹ️ Review info
⚙️ Run configuration

Configuration used: Organization UI

Review profile: CHILL

Plan: Pro

Run ID: 2c6c60cb-3b84-4c66-86ec-4c40d26bbbd4

📥 Commits

Reviewing files that changed from the base of the PR and between 51a857f and d6e9609.

📒 Files selected for processing (3)
  • includes/fields/class-fieldtypes-facebook.php
  • includes/fields/class-fieldtypes-social.php
  • includes/fields/class-fieldtypes-twitter.php

Comment thread includes/fields/class-fieldtypes-social.php Outdated
Comment thread includes/fields/class-fieldtypes-social.php
Comment thread includes/fields/class-fieldtypes-twitter.php
@Strategy11 Strategy11 deleted a comment from coderabbitai Bot Apr 14, 2026
@sorinmarta sorinmarta merged commit 035bce6 into master Apr 14, 2026
5 checks passed
@sorinmarta sorinmarta deleted the fix-351 branch April 14, 2026 06:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

run analysis Runs phpcs and phpunit

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants