Fix 355: Add missing nonce to form field and fees drag-and-drop reorder AJAX requests#502
Merged
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
This PR fixes admin drag-and-drop reordering for Form Fields and Fees by adding the missing nonce parameter to the related AJAX POST requests, aligning the JS payload with the PHP handlers’ check_ajax_referer( 'wpbdp_ajax', 'nonce', false ) checks (fixes Strategy11/business-directory-premium#355).
Changes:
- Add
nonce: wpbdp_global.nonceto thewpbdp-formfields-reorderAJAX request. - Add
nonce: wpbdp_global.nonceto thewpbdp-admin-fees-reorderAJAX request.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
nonceparameter to thewpbdp-formfields-reorderAJAX call inassets/js/admin.js(line 253)nonceparameter to thewpbdp-admin-fees-reorderAJAX call inassets/js/admin.js(line 496)wpbdp_global.nonce, which is already localized to the page viawp_localize_scriptinincludes/class-assets.phpcheck_ajax_referer( 'wpbdp_ajax', 'nonce', false )which silently rejected the requests without the nonceFixes Strategy11/business-directory-premium#355
Test plan
nonceand returns{"success":true,...}