Support string $upgrade_link_args in FrmAddonsController::conditional_action_button#1406
Merged
Conversation
Codecov ReportAttention:
Additional details and impacted files@@ Coverage Diff @@
## master #1406 +/- ##
============================================
- Coverage 29.12% 29.11% -0.01%
- Complexity 7294 7295 +1
============================================
Files 105 105
Lines 24058 24060 +2
============================================
Hits 7006 7006
- Misses 17052 17054 +2 ☔ View full report in Codecov by Sentry. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #1405
The welcome page passes
views-infofor the upgrade link args. The function was setting an array key, which causes issues when the variable isn't an array.This update sets it to an array. By the time
FrmAppHelper::admin_upgrade_linkis called, we no longer need themediumvalue being passed in$upgrade_link_args. If it's a string, it's fine to set it to an empty array.The next line sets the link as before, now with an array value.