Make form API error handling support string errors#1504
Merged
Crabcyborg merged 1 commit intoFeb 14, 2024
Conversation
Codecov ReportAttention:
Additional details and impacted files@@ Coverage Diff @@
## master #1504 +/- ##
============================================
+ Coverage 29.43% 29.47% +0.03%
- Complexity 7673 7676 +3
============================================
Files 115 115
Lines 25354 25357 +3
============================================
+ Hits 7463 7474 +11
+ Misses 17891 17883 -8 ☔ View full report in Codecov by Sentry. |
stephywells
approved these changes
Feb 14, 2024
Contributor
stephywells
left a comment
stephywells
left a comment
There was a problem hiding this comment.
This should be fixed from the Cloudflare end, but we could still merge this if you'd like. It's a nice simple fix.
Crabcyborg
deleted the
make_form_api_error_handling_support_string_errors
branch
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Related tickets
https://secure.helpscout.net/conversation/2506175920/189635
https://secure.helpscout.net/conversation/2506108172/189628/
It looks like an error for a nulled license works differently.
Instead of the expected
$addons['error']array, it's a string like "Your license has been blocked!".The "Y" shows up in PHP 7.4.
In PHP 8 it throws a fatal error instead,
The error seems to be causing issues with disconnecting a nulled license. I couldn't figure out where this is being defined though. When I searched the error message, I couldn't find where this message was actually coming from.
Pre-release,
formidable-6.8.1b.zip