Add a filter that allows updating label positions

[AbdiTolesa]

Related issue https://github.com/Strategy11/formidable-pro/issues/3849
Required for https://github.com/Strategy11/formidable-pro/pull/4947

[coderabbitai]

Walkthrough

The FrmStylesHelper class was updated to enhance the get_single_label_positions method. This method now accepts a $field parameter, enabling it to cater to specific field requirements. Additionally, a filter hook frm_single_label_positions was introduced, providing developers with the ability to update label positions within field settings dynamically.

Changes

File	Change Summary
classes/helpers/FrmStylesHelper.php	Updated get_single_label_positions method to accept $field parameter, and added frm_single_label_positions filter hook.
classes/views/frm-fields/back-end/settings.php	Modified function call to FrmStylesHelper::get_single_label_positions() to include an additional parameter $field.

Sequence Diagram(s)

sequenceDiagram
    participant Developer
    participant FrmStylesHelper
    Developer ->> FrmStylesHelper: Call get_single_label_positions($field)
    FrmStylesHelper -->> Developer: Return default label positions
    FrmStylesHelper ->>+ Filter Hook: frm_single_label_positions($label_positions, $field)
    Filter Hook -->>- FrmStylesHelper: Modified label positions
    FrmStylesHelper -->> Developer: Return updated label positions

Loading

---

Recent review details

Configuration used: CodeRabbit UI
Review profile: CHILL

Commits

Files that changed from the base of the PR and between 5b09371 and eab4506.

Files selected for processing (1)

• classes/helpers/FrmStylesHelper.php (2 hunks)

---

Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

Share

• X
• Mastodon
• Reddit
• LinkedIn

Tips

Chat

There are 3 ways to chat with CodeRabbit:

• Review comments: Directly reply to a review comment made by CodeRabbit. Example:
  • I pushed a fix in commit <commit_id>.
  • Generate unit testing code for this file.
  • Open a follow-up GitHub issue for this discussion.
• Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
  • @coderabbitai generate unit testing code for this file.
  • @coderabbitai modularize this function.
• PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
  • @coderabbitai generate interesting stats about this repository and render them as a table.
  • @coderabbitai show all the console.log statements in this repository.
  • @coderabbitai read src/utils.ts and generate unit testing code.
  • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
  • @coderabbitai help me debug CodeRabbit configuration file.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (invoked as PR comments)

• @coderabbitai pause to pause the reviews on a PR.
• @coderabbitai resume to resume the paused reviews.
• @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
• @coderabbitai full review to do a full review from scratch and review all the files again.
• @coderabbitai summary to regenerate the summary of the PR.
• @coderabbitai resolve resolve all the CodeRabbit review comments.
• @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
• @coderabbitai help to get help.

Additionally, you can add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.

CodeRabbit Configration File (.coderabbit.yaml)

• You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
• Please see the configuration documentation for more information.
• If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

• Visit our Documentation for detailed information on how to use CodeRabbit.
• Join our Discord Community to get help, request features, and share feedback.
• Follow us on X/Twitter for updates and announcements.

[coderabbitai]

Actionable comments posted: 1

[truongwp]

This looks good! Thanks @AbdiTolesa!

[coderabbitai]

Actionable comments posted: 1

Outside diff range and nitpick comments (1)

classes/helpers/FrmStylesHelper.php (1)

Line range hint 41-67: Ensure the $field parameter is utilized effectively within get_single_label_positions.

The $field parameter is added but not used within the method logic. This could be an oversight or a placeholder for future enhancements. Please confirm its intended use or consider removing it if it's unnecessary.

[Crabcyborg]

I think this is good to merge now.

Thanks @AbdiTolesa and @truongwp!

🚀