Skip to content

Pro issue 5074 / Print media templates to fix email actions media but… #1751

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
Crabcyborg merged 4 commits into from
May 24, 2024
Merged

Pro issue 5074 / Print media templates to fix email actions media but… #1751

Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
db3dca9
Pro issue 5074 / Print media templates to fix email actions media but…
Crabcyborg May 22, 2024
3039019
Fix spacing change
Crabcyborg May 22, 2024
1f772c7
Add a since comment
Crabcyborg May 22, 2024
0232d08
Fixing change (phpcs)
Crabcyborg May 22, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
23 changes: 23 additions & 0 deletions classes/controllers/FrmFormsController.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1232,6 +1232,8 @@ public static function get_settings_vars( $id, $errors = array(), $args = array(

global $frm_vars;

self::maybe_print_media_templates();

if ( ! is_array( $args ) ) {
// For reverse compatibility.
$args = array(
Expand Down Expand Up @@ -1269,6 +1271,27 @@ public static function get_settings_vars( $id, $errors = array(), $args = array(
require FrmAppHelper::plugin_path() . '/classes/views/frm-forms/settings.php';
}

/**
* Print WordPress media templates email actions does not trigger a "Uncaught Error: Template not found: #tmpl-media-selection" error when the media button is clicked.
*
* @since x.x
*
* @return void
*/
private static function maybe_print_media_templates() {
if ( FrmAppHelper::pro_is_included() ) {
// This issue does not exist when Pro is active so exit early.
return;
}

add_action(
'wp_enqueue_editor',
function () {
wp_print_media_templates();
}
);
}

/**
* @since 4.0
*/
Expand Down