Skip to content
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions .github/workflows/syntax.yml
Original file line number Diff line number Diff line change
Expand Up @@ -16,8 +16,8 @@ jobs:
strategy:
matrix:
include:
- php: 5.6
- php: 8.1
- php: 7.0
- php: 8.3
steps:
- uses: actions/checkout@v4.1.1

Expand Down
12 changes: 12 additions & 0 deletions changelog.txt
Original file line number Diff line number Diff line change
@@ -1,4 +1,16 @@
== Changelog ==
= 6.10 =
* New: Field data for shortcodes is now stored in memory and reused on the settings page and form builder page for a significant page load speed improvement for forms with a lot of fields.
* New: XML import has been updated to support mapping field ID changes when importing a map view and new calendar view settings.
* Fix: Payments using a currency that uses a comma as the decimal separator would have an incorrect amount value when the amount value had a single decimal point like 11,5.
* Fix: Field error elements would inconsistently use either IDs or field keys in their ID values. An update has been made to use always use field keys.
* Fix: In some cases, a Stripe redirect would happen after failing to create an entry, resulting in an unexpected redirect to stripe.com.
* The minimum supported PHP version has been updated to 7.0, ending official support for PHP 5.6.
* The frm_summary_email_content_args hook has been moved to where it is now filtered for all types of email summaries.
* Several deprecated PHP functions have been removed including FrmFormsHelper::template_install_html, FrmFormsHelper::available_count, FrmFormsHelper::builder_submit_button, FrmFieldsHelper::get_shortcode_tag, FrmFieldsController::include_single_field, and FrmFormsController::new_form.
* Several deprecated front end JavaScript functions have been removed including frmFrontForm.goingToPreviousPage, frmFrontForm.hideOrShowFields, frmFrontForm.hidePreviouslyHiddenFields, frmFrontForm.checkDependentDynamicFields, frmFrontForm.checkDependentLookupFields, and frmFrontForm.loadGoogle.
* Some front end JavaScript code for supporting Internet Explorer has been dropped, helping to reduce the size of JavaScript required on the front end.

= 6.9.1 =
* New: Some data used for field settings is now stored in memory and reused in order to significantly improve performance in the form builder for forms with a lot of fields.
* Fix: Rootline and progress bar elements would not appear when using some position settings with the new submit button field.
Expand Down
2 changes: 1 addition & 1 deletion classes/helpers/FrmAppHelper.php
Original file line number Diff line number Diff line change
Expand Up @@ -3519,7 +3519,7 @@ public static function meets_min_pro_version( $min_version ) {
*/
private static function php_version_notice() {
$message = array();
if ( version_compare( phpversion(), '5.6', '<' ) ) {
if ( version_compare( phpversion(), '7.0', '<' ) ) {
Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fix the syntax error due to the stray character.

Committable suggestion was skipped due low confidence.

$message[] = __( 'The version of PHP on your server is too low. If this is not corrected, you may see issues with Formidable Forms. Please contact your web host and ask to be updated to PHP 7.0+.', 'formidable' );
}

Expand Down
35 changes: 15 additions & 20 deletions readme.txt
Original file line number Diff line number Diff line change
Expand Up @@ -3,9 +3,9 @@ Plugin Name: Formidable Forms - Contact Form, Survey & Quiz Form Builder for Wor
Contributors: formidableforms, sswells, srwells
Tags: forms, form builder, survey, free, custom form, contact form, form maker, form creator, paypal, stripe, stripe form, quote form, contact button, form manager, payment form, survey form, email subscription, donation form, user registration form, wordpress registration, feedback form
Requires at least: 5.2
Tested up to: 6.5.2
Requires PHP: 5.6
Stable tag: 6.9.1
Tested up to: 6.5.3
Requires PHP: 7.0
Stable tag: 6.10

The most advanced WordPress forms plugin. Go beyond contact forms with our drag and drop form builder for surveys, quizzes, and more.

Expand Down Expand Up @@ -371,6 +371,18 @@ Using our Zapier integration, you can easily connect your website with over 5,00
See all [Formidable Zapier Integrations](https://zapier.com/apps/formidable/integrations).

== Changelog ==
= 6.10 =
* New: Field data for shortcodes is now stored in memory and reused on the settings page and form builder page for a significant page load speed improvement for forms with a lot of fields.
* New: XML import has been updated to support mapping field ID changes when importing a map view and new calendar view settings.
* Fix: Payments using a currency that uses a comma as the decimal separator would have an incorrect amount value when the amount value had a single decimal point like 11,5.
* Fix: Field error elements would inconsistently use either IDs or field keys in their ID values. An update has been made to use always use field keys.
* Fix: In some cases, a Stripe redirect would happen after failing to create an entry, resulting in an unexpected redirect to stripe.com.
* The minimum supported PHP version has been updated to 7.0, ending official support for PHP 5.6.
* The frm_summary_email_content_args hook has been moved to where it is now filtered for all types of email summaries.
* Several deprecated PHP functions have been removed including FrmFormsHelper::template_install_html, FrmFormsHelper::available_count, FrmFormsHelper::builder_submit_button, FrmFieldsHelper::get_shortcode_tag, FrmFieldsController::include_single_field, and FrmFormsController::new_form.
* Several deprecated front end JavaScript functions have been removed including frmFrontForm.goingToPreviousPage, frmFrontForm.hideOrShowFields, frmFrontForm.hidePreviouslyHiddenFields, frmFrontForm.checkDependentDynamicFields, frmFrontForm.checkDependentLookupFields, and frmFrontForm.loadGoogle.
* Some front end JavaScript code for supporting Internet Explorer has been dropped, helping to reduce the size of JavaScript required on the front end.
Comment on lines +374 to +384
Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tip

Codebase Verification

The verification process has revealed that while the deprecated PHP functions have been successfully removed, several deprecated JavaScript functions still exist in the codebase, specifically within js/formidable.min.js.

  • frmFrontForm.goingToPreviousPage
  • frmFrontForm.hideOrShowFields
  • frmFrontForm.hidePreviouslyHiddenFields
  • frmFrontForm.checkDependentDynamicFields
  • frmFrontForm.checkDependentLookupFields
  • frmFrontForm.loadGoogle

These functions are marked as deprecated but are still present in the minified JavaScript file.

Analysis chain

Changelog for version 6.10:

  • New features like improved field data storage and XML import functionality are beneficial for performance and flexibility.
  • Fixes for currency decimal issues and field error elements enhance reliability.
  • Updates related to PHP version and deprecated functions improve security and future-proofing.
  • Removal of Internet Explorer-specific JavaScript optimizes front-end performance.

Ensure all deprecated functions are removed from the codebase and update documentation accordingly.

Scripts Executed

The following scripts were executed for the analysis:


Script:

#!/bin/bash
# Description: Verify that all deprecated functions are removed from the codebase.

# Test: Search for deprecated functions. Expect: No occurrences.
rg --type php 'FrmFormsHelper::template_install_html|FrmFormsHelper::available_count|FrmFormsHelper::builder_submit_button|FrmFieldsHelper::get_shortcode_tag|FrmFieldsController::include_single_field|FrmFormsController::new_form'

Length of output: 231



Script:

#!/bin/bash
# Description: Verify that all deprecated functions are removed from the codebase.

# Test: Search for deprecated PHP functions. Expect: No occurrences.
rg --type php 'FrmFormsHelper::template_install_html|FrmFormsHelper::available_count|FrmFormsHelper::builder_submit_button|FrmFieldsHelper::get_shortcode_tag|FrmFieldsController::include_single_field|FrmFormsController::new_form'

# Test: Search for deprecated JavaScript functions. Expect: No occurrences.
rg --type js 'frmFrontForm.goingToPreviousPage|frmFrontForm.hideOrShowFields|frmFrontForm.hidePreviouslyHiddenFields|frmFrontForm.checkDependentDynamicFields|frmFrontForm.checkDependentLookupFields|frmFrontForm.loadGoogle'

Length of output: 2217


= 6.9.1 =
* New: Some data used for field settings is now stored in memory and reused in order to significantly improve performance in the form builder for forms with a lot of fields.
* Fix: Rootline and progress bar elements would not appear when using some position settings with the new submit button field.
Expand Down Expand Up @@ -403,23 +415,6 @@ See all [Formidable Zapier Integrations](https://zapier.com/apps/formidable/inte
* Monthly summary emails will no longer get sent when there are no new entries to report on.
* The global JS function frm_add_logic_row used on admin pages has been removed.

= 6.8.3 =
* New: HTML field descriptions now support the shortcode pop up used in email actions.
* New: Exported posts from entries will now include <term_parent> tags when applicable.
* New: The collapsible sections used in the visual styler are now more accessible, including new aria-expanded attributes.
* New: Error messages should now be more descriptive. "This field" and "This value" strings will now be dynamically replaced with the name of the field. To partially revert this, a new frm_error_substrings_to_replace_with_field_name filter has been added as well.
* Fix: Form objects with missing option data would trigger fatal errors during various actions, including when deleting the form.
* Fix: HTML tags would get stripped of most HTML when displayed in a summary for a unprivileged or logged out user.
* Fix: A Uncaught TypeError: Cannot access offset of type string on string error has been fixed when checking for add-on data.
* Fix: License expired emails would get incorrectly sent for rate limited API requests.
* Fix: Some color style settings would output invalid RGB values when using a RGB color as the style setting value.
* API requests sent for retreiving add-on and template data will now happen less frequently.
* A few old deprecated global JavaScript functions have been removed including frm_resend_email, frmOnSubmit, and frmDeleteEntry.
* Some old CSS rules using -webkit- and -moz- prefixes have been removed, helping to reduce CSS file size.

= 6.8.2 =
* Fix: The process of connecting an account to formidableforms.com would fail in some web browsers.

[See changelog for all versions](https://raw.githubusercontent.com/Strategy11/formidable-forms/master/changelog.txt)

== Upgrade Notice ==
Expand Down