Skip to content

Make sure popper is registered for legacy Views #1873

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
Crabcyborg merged 4 commits into from
Jul 25, 2024
Merged

Make sure popper is registered for legacy Views #1873

Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
f6a01f8
Make sure popper is registered for legacy Views
AbdiTolesa Jul 19, 2024
b99d8f0
Improve code readability
AbdiTolesa Jul 19, 2024
162603d
Simplify code a bit
AbdiTolesa Jul 19, 2024
5140eb9
Simplify logic
AbdiTolesa Jul 22, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
19 changes: 16 additions & 3 deletions classes/controllers/FrmAppController.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -933,10 +933,23 @@ private static function register_popper1() {
private static function should_register_popper() {
global $pagenow;

$page = FrmAppHelper::simple_get( 'page', 'sanitize_title' );
$post_type = FrmAppHelper::simple_get( 'post_type', 'sanitize_title' );
$post_id = FrmAppHelper::simple_get( 'post', 'absint' );
if ( 'post.php' === $pagenow && $post_id && 'frm_display' === get_post_type( $post_id ) ) {
return true;
}

$post_type = FrmAppHelper::simple_get( 'post_type', 'sanitize_title' );
$is_views_post_type = 'frm_display' === $post_type;
if ( in_array( $pagenow, array( 'post-new.php', 'edit.php' ), true ) && $is_views_post_type ) {
return true;
}

$page = FrmAppHelper::simple_get( 'page', 'sanitize_title' );
if ( strpos( $page, 'formidable' ) === 0 ) {
return true;
}

return strpos( $page, 'formidable' ) === 0 || ( $pagenow === 'edit.php' && $post_type === 'frm_display' ) || ( in_array( $pagenow, array( 'term.php', 'edit-tags.php' ), true ) && FrmAppHelper::simple_get( 'taxonomy' ) === 'frm_application' );
return in_array( $pagenow, array( 'term.php', 'edit-tags.php' ), true ) && FrmAppHelper::simple_get( 'taxonomy' ) === 'frm_application';
}

/**
Expand Down