Prevent user id field from being dragged into field group

[AbdiTolesa]

Fix https://github.com/Strategy11/formidable-pro/issues/5225

[coderabbitai]

Walkthrough

The recent changes to the frmAdminBuildJS function improve the drag-and-drop functionality within sortable lists. By implementing conditional checks to exclude elements with the class edit_field_type_user_id, the code effectively prevents these user ID fields from being draggable. This enhancement refines user interactions, ensuring that only appropriate items can be moved, thereby creating a more focused and user-friendly experience within the admin interface.

Changes

Files	Change Summary
js/formidable_admin.js	Enhanced drag-and-drop functionality by introducing checks for elements with the class edit_field_type_user_id, preventing them from being draggable. Additional logic ensures user ID fields are not included in drag-and-drop actions.

Sequence Diagram(s)

sequenceDiagram
    participant User
    participant SortableList
    participant DraggableItems

    User->>SortableList: Initiate drag
    SortableList->>DraggableItems: Check if item is draggable
    alt Item is draggable
        DraggableItems-->>User: Allow drag
    else Item is not draggable
        DraggableItems-->>User: Prevent drag action
    end

Loading

---

Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

Share

• X
• Mastodon
• Reddit
• LinkedIn

Tips

Chat

There are 3 ways to chat with CodeRabbit:

• Review comments: Directly reply to a review comment made by CodeRabbit. Example:
  • I pushed a fix in commit <commit_id>.
  • Generate unit testing code for this file.
  • Open a follow-up GitHub issue for this discussion.
• Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
  • @coderabbitai generate unit testing code for this file.
  • @coderabbitai modularize this function.
• PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
  • @coderabbitai generate interesting stats about this repository and render them as a table.
  • @coderabbitai show all the console.log statements in this repository.
  • @coderabbitai read src/utils.ts and generate unit testing code.
  • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
  • @coderabbitai help me debug CodeRabbit configuration file.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (invoked as PR comments)

• @coderabbitai pause to pause the reviews on a PR.
• @coderabbitai resume to resume the paused reviews.
• @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
• @coderabbitai full review to do a full review from scratch and review all the files again.
• @coderabbitai summary to regenerate the summary of the PR.
• @coderabbitai resolve resolve all the CodeRabbit review comments.
• @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
• @coderabbitai help to get help.

Additionally, you can add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.

CodeRabbit Configuration File (.coderabbit.yaml)

• You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
• Please see the configuration documentation for more information.
• If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

• Visit our Documentation for detailed information on how to use CodeRabbit.
• Join our Discord Community to get help, request features, and share feedback.
• Follow us on X/Twitter for updates and announcements.

[Crabcyborg]

Thanks for working on this @AbdiTolesa.

I moved some code around and fixed an issue where you could still drag fields beside a user ID field in a field group that way.

The user ID check makes more sense where the hidden field check is, and the function groupIncludesBreakOrHidden needed to also start checking for user id fields since that helper function covers the similar issue with hidden fields.

I think this is good to go now.

🚀

[AbdiTolesa]

Thanks for working on this @AbdiTolesa.

I moved some code around and fixed an issue where you could still drag fields beside a user ID field in a field group that way.

The user ID check makes more sense where the hidden field check is, and the function groupIncludesBreakOrHidden needed to also start checking for user id fields since that helper function covers the similar issue with hidden fields.

I think this is good to go now.

🚀

Thanks @Crabcyborg!