Stop using font icons for form actions collapsible

[AbdiTolesa]

Fix https://github.com/Strategy11/formidable-pro/issues/5249

[coderabbitai]

Walkthrough

The recent changes enhance both the PHP and CSS components of the codebase. The PHP file now employs a dynamic function for rendering icons, which improves maintainability. In CSS, modifications focus on the layout and aesthetics of notification settings and button styles, with adjustments to padding and consistent color schemes for SVG icons. Collectively, these updates aim to improve user interface design and code flexibility.

Changes

File Path	Change Summary
classes/views/frm-form-actions/...	Replaced static HTML icon with a dynamic PHP function call for enhanced management and flexibility of icon rendering.
css/frm_admin.css	Added padding for .widget-action and modified button styles, including a 90-degree rotation of SVG icons and color adjustments for consistency.

Sequence Diagram(s)

sequenceDiagram
    participant User
    participant Button
    participant IconRenderer

    User->>Button: Clicks button
    Button->>IconRenderer: Request icon rendering
    IconRenderer-->>Button: Returns rendered icon
    Button->>User: Displays button with icon

Loading

---

Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

Share

• X
• Mastodon
• Reddit
• LinkedIn

Tips

Chat

There are 3 ways to chat with CodeRabbit:

• Review comments: Directly reply to a review comment made by CodeRabbit. Example:
  • I pushed a fix in commit <commit_id>.
  • Generate unit testing code for this file.
  • Open a follow-up GitHub issue for this discussion.
• Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
  • @coderabbitai generate unit testing code for this file.
  • @coderabbitai modularize this function.
• PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
  • @coderabbitai generate interesting stats about this repository and render them as a table.
  • @coderabbitai show all the console.log statements in this repository.
  • @coderabbitai read src/utils.ts and generate unit testing code.
  • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
  • @coderabbitai help me debug CodeRabbit configuration file.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (invoked as PR comments)

• @coderabbitai pause to pause the reviews on a PR.
• @coderabbitai resume to resume the paused reviews.
• @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
• @coderabbitai full review to do a full review from scratch and review all the files again.
• @coderabbitai summary to regenerate the summary of the PR.
• @coderabbitai resolve resolve all the CodeRabbit review comments.
• @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
• @coderabbitai help to get help.

Additionally, you can add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.

CodeRabbit Configuration File (.coderabbit.yaml)

• You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
• Please see the configuration documentation for more information.
• If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

• Visit our Documentation for detailed information on how to use CodeRabbit.
• Join our Discord Community to get help, request features, and share feedback.
• Follow us on X/Twitter for updates and announcements.

[truongwp]

@AbdiTolesa I think we can remove this CSS

formidable-forms/css/frm_admin.css

Line 6799 in 62e5898

.open .widget-top .frm_arrow_right_icon:before {

[truongwp]

We should add transition for the icon, the previous <i> tag has a transition CSS rule. We can copy it for the svg and probably remove the CSS rule for that <i> tag.

[AbdiTolesa]

We should add transition for the icon, the previous <i> tag has a transition CSS rule. We can copy it for the svg and probably remove the CSS rule for that <i> tag.

@truongwp I have removed the old css, thanks! I didn't see any significant transition effect for the old <i> tag, are you referring to the the transition below? It doesn't really have any noticeable effect to my eyes if so.

[truongwp]

@AbdiTolesa Sorry, the old tag doesn't have the transition for rotation.

[truongwp]

This looks good. Thanks @AbdiTolesa!

[Crabcyborg]

Thanks @AbdiTolesa and @truongwp for working on this!

I think this is good to merge.

🚀