Replace font icons with SVGs for edd license status

[AbdiTolesa]

Fix https://github.com/Strategy11/formidable-pro/issues/5251

Enhancements:

• Switched from using font icons to SVGs.
• User can add/remove license without refreshing the page.
• The activate/deactivate button is disabled until response is received for the prior request

Test steps

1. Go to the Plugin Licenses tab in the Global Settings and try adding and removing add-on licenses.
2. Confirm that the icons reflect the action of success/error action as expected.
3. Also confirm that, a user can add/remove a license for an add-on without leaving the page, since the 'Activate' and 'Deactivate' elements toggle after few seconds of action.

[coderabbitai]

Walkthrough

The recent updates focus on enhancing the rendering, styling, and visibility control of icons in the license activation interface and form icons. Static icon class definitions have been replaced with dynamic function calls, transitioning from font-based icons to SVG for improved visual consistency. Additionally, the logic for displaying icons based on message states has been refined for better user interface responsiveness.

Changes

Files	Change Summary
classes/views/addons/settings.php	Updated icon rendering by replacing static class definitions with dynamic function calls to FrmAppHelper::icon_by_class(), enhancing maintainability and flexibility.
css/frm_admin.css	Renamed icon class from .frm_icon_font to .frmsvg for SVG graphics; changed property from color to fill for SVG compatibility; added new classes for success and error icons.
js/formidable_admin.js	Enhanced control of icon visibility based on message success or error states, ensuring the correct icons are displayed or hidden, thus improving UI responsiveness.

---

Recent review details

Configuration used: CodeRabbit UI
Review profile: CHILL

Commits

Files that changed from the base of the PR and between 504830c and 84d77c9.

Files selected for processing (1)

• js/formidable_admin.js (1 hunks)

Files skipped from review as they are similar to previous changes (1)

• js/formidable_admin.js

---

Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

Share

• X
• Mastodon
• Reddit
• LinkedIn

Tips

Chat

There are 3 ways to chat with CodeRabbit:

• Review comments: Directly reply to a review comment made by CodeRabbit. Example:
  • I pushed a fix in commit <commit_id>.
  • Generate unit testing code for this file.
  • Open a follow-up GitHub issue for this discussion.
• Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
  • @coderabbitai generate unit testing code for this file.
  • @coderabbitai modularize this function.
• PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
  • @coderabbitai generate interesting stats about this repository and render them as a table.
  • @coderabbitai show all the console.log statements in this repository.
  • @coderabbitai read src/utils.ts and generate unit testing code.
  • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
  • @coderabbitai help me debug CodeRabbit configuration file.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (invoked as PR comments)

• @coderabbitai pause to pause the reviews on a PR.
• @coderabbitai resume to resume the paused reviews.
• @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
• @coderabbitai full review to do a full review from scratch and review all the files again.
• @coderabbitai summary to regenerate the summary of the PR.
• @coderabbitai resolve resolve all the CodeRabbit review comments.
• @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
• @coderabbitai help to get help.

Additionally, you can add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.

CodeRabbit Configuration File (.coderabbit.yaml)

• You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
• Please see the configuration documentation for more information.
• If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

• Visit our Documentation for detailed information on how to use CodeRabbit.
• Join our Discord Community to get help, request features, and share feedback.
• Follow us on X/Twitter for updates and announcements.

[AbdiTolesa]

@Crabcyborg I have replaced the icons on load (PHP) now. Are those icons changed with js when the license for a given plugin is activated/deactivated. If so, is there a plugin license I can use for test that you can share me?

[Crabcyborg]

@AbdiTolesa I left a reply on the issue. Since this is a public repo I didn't want to share any license keys here.

https://github.com/Strategy11/formidable-pro/issues/5251#issuecomment-2288733953

[garretlaxton]

This looks great!

[truongwp]

This looks good now. Thanks @AbdiTolesa!

[Crabcyborg]

I think this is probably good enough. I was going to try making a PR with some improvements but I see that it's probably more work than it's worth.

Thank you @AbdiTolesa @truongwp and @garretlaxton for working on this!

🚀