Skip to content

Fix JS error when trying to validate readonly time field #1946

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
Crabcyborg merged 1 commit into from
Aug 23, 2024
Merged

Fix JS error when trying to validate readonly time field #1946

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 6 additions & 0 deletions js/formidable.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -352,6 +352,12 @@ function frmFrontFormJS() {
fieldID = getFieldId( field, true );
}

// Make sure fieldID is a string.
// fieldID may be a number which doesn't include a .replace function.
if ( 'function' !== typeof fieldID.replace ) {
fieldID = fieldID.toString();
}

if ( hasClass( field, 'frm_time_select' ) ) {
// set id for time field
fieldID = fieldID.replace( '-H', '' ).replace( '-m', '' );
Expand Down