Skip to content

Prepare for 6.15#2021

Merged
Crabcyborg merged 4 commits into
masterfrom
prepare_for_6.15
Oct 2, 2024
Merged

Prepare for 6.15#2021
Crabcyborg merged 4 commits into
masterfrom
prepare_for_6.15

Conversation

@Crabcyborg
Copy link
Copy Markdown
Contributor

No description provided.

@Crabcyborg Crabcyborg marked this pull request as ready for review October 2, 2024 16:53
@coderabbitai
Copy link
Copy Markdown
Contributor

coderabbitai Bot commented Oct 2, 2024

Caution

Review failed

The pull request is closed.

Walkthrough

The pull request implements a series of updates across multiple files, primarily focused on versioning and documentation enhancements. Key changes include updating @since annotations to reflect the correct version for various methods and classes, introducing a new method in FrmAddonsController, and modifying the version number in the main plugin file. Additionally, several JavaScript files underwent significant refactoring to improve code organization and maintainability, while also enhancing functionality and user experience.

Changes

File Path Change Summary
classes/controllers/FrmAddonsController.php Updated @since annotations for several methods to 6.15 and added deactivate_plugin method with @since 6.8.
classes/controllers/FrmDeactivationFeedbackController.php Updated @since annotation to 6.15.
classes/helpers/FrmAddonsHelper.php Updated @since annotations for multiple methods and the class itself to 6.15.
classes/helpers/FrmAppHelper.php Updated $plug_version from 6.14.1 to 6.15 and @since annotation for print_setting_error to 6.15.
classes/helpers/FrmEmailHelper.php Updated @since annotation for get_default_from_email method to 6.15.
classes/helpers/FrmFormsHelper.php Updated @since annotations for convert_legacy_package_names and get_license_types to 6.15, and marked ignore_template_categories as deprecated.
classes/models/FrmAddon.php Updated documentation for plugins_api_filter method and changed visibility of lock_key and is_running methods to protected.
classes/models/FrmField.php Updated @since annotation for add_slashes_to_format_before_setting_field_cache to 6.15.
formidale.php Updated version number from 6.14.1 to 6.15.
js/addons-page.js Refactored code for improved modularity, added new functions, and enhanced event handling logic.
js/formidable.js Updated validation functions to include an onSubmit parameter and improved overall form validation logic.
js/formidable_admin.js Enhanced functionality of form builder, refined event handling, and improved AJAX requests.
js/formidable_blocks.js Introduced new components and updated rendering logic for forms in the WordPress block editor.
js/formidable_dashboard.js Refactored code for better readability and maintainability without changing functionality.
js/formidable_overlay.js Refactored overlay management code into a new class structure while maintaining original functionality.
js/formidable_styles.js Refactored styles management into classes for improved modularity and readability.
js/src/onboarding-wizard/ui/showError.js Updated @since annotation for showEmailAddressError function to 6.15.
languages/formidable.pot Updated version number to 6.15, modified creation date, and added new translation strings.
stripe/js/frmstrp.js Adjusted parameter type annotation in each function for clarity, retaining original logic.

Possibly related PRs

  • New Add-Ons Page #1802: The changes in FrmAddonsController.php are related to the main PR as both involve updates to the same class, specifically focusing on versioning and documentation improvements.
  • Update Default Form Styling #1640: This PR updates versioning annotations in various helper classes, which aligns with the main PR's focus on updating @since annotations in the FrmAddonsController.php.
  • Update readme 6.15 #2016: The changelog updates in this PR reflect enhancements and fixes that include versioning changes, similar to the documentation updates in the main PR.
  • Prepare for 6.14 #1975: This PR also involves updating versioning information in various classes, which is a key aspect of the main PR's changes.
  • fix error fields style when underline is used as field shape type #1982: The changes in FrmStylesHelper.php regarding error handling and styling are relevant as they may relate to the overall improvements in the plugin's functionality, which is a broader context of the main PR's updates.

Suggested reviewers

  • garretlaxton
  • shervElmi
  • truongwp

Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

❤️ Share
🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

  • Review comments: Directly reply to a review comment made by CodeRabbit. Example:
    • I pushed a fix in commit <commit_id>, please review it.
    • Generate unit testing code for this file.
    • Open a follow-up GitHub issue for this discussion.
  • Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
    • @coderabbitai generate unit testing code for this file.
    • @coderabbitai modularize this function.
  • PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
    • @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
    • @coderabbitai read src/utils.ts and generate unit testing code.
    • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
    • @coderabbitai help me debug CodeRabbit configuration file.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

  • @coderabbitai pause to pause the reviews on a PR.
  • @coderabbitai resume to resume the paused reviews.
  • @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
  • @coderabbitai full review to do a full review from scratch and review all the files again.
  • @coderabbitai summary to regenerate the summary of the PR.
  • @coderabbitai resolve resolve all the CodeRabbit review comments.
  • @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
  • @coderabbitai help to get help.

Other keywords and placeholders

  • Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
  • Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
  • Add @coderabbitai anywhere in the PR title to generate the title automatically.

CodeRabbit Configuration File (.coderabbit.yaml)

  • You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
  • Please see the configuration documentation for more information.
  • If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

  • Visit our Documentation for detailed information on how to use CodeRabbit.
  • Join our Discord Community to get help, request features, and share feedback.
  • Follow us on X/Twitter for updates and announcements.

@codecov
Copy link
Copy Markdown

codecov Bot commented Oct 2, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 27.17%. Comparing base (d2b2e65) to head (9476ab6).
Report is 263 commits behind head on master.

Additional details and impacted files
@@             Coverage Diff              @@
##             master    #2021      +/-   ##
============================================
- Coverage     27.40%   27.17%   -0.24%     
- Complexity     8002     8091      +89     
============================================
  Files           125      127       +2     
  Lines         26693    27054     +361     
============================================
+ Hits           7316     7352      +36     
- Misses        19377    19702     +325     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@Crabcyborg Crabcyborg merged commit 032aa0a into master Oct 2, 2024
@Crabcyborg Crabcyborg deleted the prepare_for_6.15 branch October 2, 2024 16:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant