-
Notifications
You must be signed in to change notification settings - Fork 41
Set aria-invalid to true only on name part input with error #2036
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Crabcyborg
merged 28 commits into
master
from
issue-5409-fix_name_field_validation_issue
Nov 26, 2024
Merged
Changes from all commits
Commits
Show all changes
28 commits
Select commit
Hold shift + click to select a range
c156eef
Set aria-invalid to true only on name part input with error
AbdiTolesa dbdc6b1
Move check into a separate function
AbdiTolesa 601a31c
Avoid potential bug
AbdiTolesa 9629b3c
Improve condition check
AbdiTolesa 466860a
Add missing JSDoc
AbdiTolesa d34a3ee
Cut down repeated code
AbdiTolesa 62c9d5c
Cover middle name with the fix too
AbdiTolesa 4496a70
Fix workflow errors
AbdiTolesa 1945a36
Fix workflow errors
AbdiTolesa eb3aad5
Fix workflow errors
AbdiTolesa 1c461e2
Avoid red border on textarea:focus
AbdiTolesa 432494c
Improve code readability a bit
AbdiTolesa 07bbf5e
Remove check for field type
AbdiTolesa 63a35b7
Add inline comment to explain update
AbdiTolesa 38756ec
Refactor solution to follow an object oriented approach
AbdiTolesa ff2ecd2
Remove new css selector and update existing one intended for the same…
AbdiTolesa 5972382
Move function to parent class
AbdiTolesa aa29c1c
Call getter function to get subfields for the current combo field
AbdiTolesa 16874ee
Make fix more generic
AbdiTolesa 156dc65
Merge branch 'master' into issue-5409-fix_name_field_validation_issue
Crabcyborg 51da5b1
Exit look early if already set focus on a combo subfield
AbdiTolesa b8bca3c
Merge branch 'issue-5409-fix_name_field_validation_issue' of https://…
AbdiTolesa ec33c73
Fix JSDoc error
AbdiTolesa da9377d
Fix JSDoc error
AbdiTolesa 585b814
Add missing condition check for target element's existence first
AbdiTolesa 6b01a94
Merge branch 'master' into issue-5409-fix_name_field_validation_issue
Crabcyborg 3616e9b
Merge branch 'master' into issue-5409-fix_name_field_validation_issue
Crabcyborg ab8c5cb
Use focusInput to improve support with fade in with conditional logic…
Crabcyborg File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.