Skip to content

Drop deprecated support for string where value in generate_query_stri… #2059

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
Crabcyborg merged 1 commit into from
Oct 17, 2024
Merged

Drop deprecated support for string where value in generate_query_stri… #2059

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 0 additions & 7 deletions classes/models/FrmDb.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -442,13 +442,6 @@ private static function generate_query_string_from_pieces( $columns, $table, $wh
self::get_where_clause_and_values( $where );
global $wpdb;
$query = $wpdb->prepare( $query . $where['where'] . ' ' . implode( ' ', $args ), $where['values'] ); // phpcs:ignore WordPress.DB.PreparedSQL.NotPrepared
} else {
/**
* Allow the $where to be prepared before we receive it here.
* This is a fallback for reverse compatibility, but is not recommended
*/
_deprecated_argument( 'where', '2.0', esc_html__( 'Use the query in an array format so it can be properly prepared.', 'formidable' ) );
$query .= $where . ' ' . implode( ' ', $args );
}

return $query;
Expand Down