Make field options grid clickable on mobile(iphone)

[AbdiTolesa]

Fix https://github.com/Strategy11/formidable-pro/issues/5431
Note: Go to Formidable > Styles and click on 'Update' on the styler page to generate a new stylesheet used on your pages before testing.

Test steps

1. Add a couple of checkbox fields to a form.
2. Create a Grid Layout using the steps outlined here
3. Preview the form using BrowserStack or available iPhone 14, 15, 16 within Chrome.
4. Confirm that the checkboxes are selectable when you tap on them.

[coderabbitai]

Walkthrough

The changes in this pull request primarily enhance the CSS handling for form styles within css/custom_theme.css.php. Key modifications include improved conditional logic for form styling, robust CSS output handling with sanitization, expanded use of dynamic CSS variables, updates to form element styling, and responsive design adjustments. Additionally, there are enhancements for error visibility and accessibility improvements to ensure better user experience.

Changes

File	Change Summary
css/custom_theme.css.php	- Refined conditional logic for $saving and $frm_style, instantiating $frm_style as new FrmStyle() if not set. - Enhanced CSS output handling with checks for empty $css and usage of strip_tags for sanitization. - Expanded use of dynamic CSS variables for styling adjustments based on $defaults. - Updated styles for form elements (buttons, inputs, fieldsets) incorporating new CSS variables. - Added media queries for responsive design adjustments. - Improved visibility for error messages and loading indicators based on form state. - Enhanced accessibility by ensuring proper label associations and management of hidden elements. - Added method calls: FrmStylesHelper::output_vars($defaults);, FrmStylesController::maybe_hide_sample_form_error_message();, and echo strip_tags(FrmStylesController::get_custom_css());.
classes/models/fields/FrmFieldHidden.php	- Added public method prepare_field_value($value, $atts) to handle array values and encode them as JSON if necessary.

Possibly related PRs

• Update Default Form Styling #1640: This PR updates default form styling, which is directly related to the changes in css/custom_theme.css.php in the main PR, as both involve enhancements to form element styles.
• Fix HTML display issue for checkbox with text and links #1979: This PR addresses styling for checkbox and radio button labels in css/custom_theme.css.php, which aligns with the modifications made in the main PR regarding form element styling.
• fix error fields style when underline is used as field shape type #1982: This PR introduces changes to error field styles in css/_single_theme.css.php, which is relevant to the main PR's focus on improving form styles and error handling.
• Change the UI/UX of conditional logic elements #2006: This PR enhances the styling of dropdowns used in conditional logic, which relates to the overall improvements in form styling discussed in the main PR.

Suggested labels

action: needs qa

Suggested reviewers

• Crabcyborg
• garretlaxton

---

Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

❤️ Share

• X
• Mastodon
• Reddit
• LinkedIn

🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

• Review comments: Directly reply to a review comment made by CodeRabbit. Example:
  • I pushed a fix in commit <commit_id>, please review it.
  • Generate unit testing code for this file.
  • Open a follow-up GitHub issue for this discussion.
• Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
  • @coderabbitai generate unit testing code for this file.
  • @coderabbitai modularize this function.
• PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
  • @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
  • @coderabbitai read src/utils.ts and generate unit testing code.
  • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
  • @coderabbitai help me debug CodeRabbit configuration file.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

• @coderabbitai pause to pause the reviews on a PR.
• @coderabbitai resume to resume the paused reviews.
• @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
• @coderabbitai full review to do a full review from scratch and review all the files again.
• @coderabbitai summary to regenerate the summary of the PR.
• @coderabbitai resolve resolve all the CodeRabbit review comments.
• @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
• @coderabbitai help to get help.

Other keywords and placeholders

• Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
• Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
• Add @coderabbitai anywhere in the PR title to generate the title automatically.

CodeRabbit Configuration File (.coderabbit.yaml)

• You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
• Please see the configuration documentation for more information.
• If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

• Visit our Documentation for detailed information on how to use CodeRabbit.
• Join our Discord Community to get help, request features, and share feedback.
• Follow us on X/Twitter for updates and announcements.

[coderabbitai]

Actionable comments posted: 1

📜 Review details

Configuration used: CodeRabbit UI
Review profile: CHILL

📥 Commits

Files that changed from the base of the PR and between 797b9da and 14086de.

📒 Files selected for processing (1)

• css/custom_theme.css.php (1 hunks)

🧰 Additional context used

[lauramekaj1]

@AbdiTolesa checkboxes are selectable but for example when I change the viewport dimensions to iphone15 this is how checkboxes are aligned. Maybe it's only on my end but could you please check this also?

[AbdiTolesa]

@AbdiTolesa checkboxes are selectable but for example when I change the viewport dimensions to iphone15 this is how checkboxes are aligned. Maybe it's only on my end but could you please check this also?

@lauramekaj1 I couldn't find that issue testing it again. Is that the case for you only a specific screen size or do you see that for any device size?

[lauramekaj1]

@AbdiTolesa sorry, it was just on my end. It seems to be working as expected. Thank you!

[truongwp]

I can't replicate this problem. But the code looks good to me. Thanks @AbdiTolesa!

[shervElmi]

Thanks @AbdiTolesa, it looks great to me! 🚀

[Crabcyborg]

Thanks @AbdiTolesa @truongwp @lauramekaj1 and @shervElmi!

🚀