Disable form CSS in visual styler more safely

[Crabcyborg]

I'm using a PHP 8.4 release candidate now.

This update keeps $css as an array, to help avoid conflicts with code like our Authorize.Net add-on that expects $css to be an array.

PHP Deprecated: Automatic conversion of false to array is deprecated in /var/www/src/wp-content/plugins/formidable-authorize-net/controllers/FrmAuthNetController.php on line 78

[coderabbitai]

Walkthrough

The pull request introduces modifications to the FrmStylesController class in FrmStylesController.php. Key changes include an update to the disable_form_css method to return an empty array instead of false, adjustments to the admin_init method to ensure global settings are managed, and refinements to the enqueue_css method to conditionally load styles based on the load_style setting. These updates enhance the handling of stylesheets within the admin interface.

Changes

File Path	Change Summary
classes/controllers/FrmStylesController.php	- Updated disable_form_css to return an empty array instead of false. - Modified admin_init to include a call to maybe_hook_into_global_settings_save. - Refined enqueue_css to conditionally load styles based on the load_style setting.

Possibly related PRs

• improve primary color from quick settings style editor #2054: This PR modifies the FrmStylesHelper class and related files to enhance the primary color settings, which is directly related to the changes in the FrmStylesController class regarding style management.

Suggested labels

run analysis, run tests

---

📜 Recent review details

Configuration used: CodeRabbit UI
Review profile: CHILL

📥 Commits

Files that changed from the base of the PR and between 80214bf and 2dd1c9f.

📒 Files selected for processing (1)

• classes/controllers/FrmStylesController.php (1 hunks)

🧰 Additional context used

🔇 Additional comments (2)

classes/controllers/FrmStylesController.php (2)

99-99: LGTM: Type-safe filter callback change.

The change from __return_false to __return_empty_array is a good fix for PHP 8.4 compatibility, ensuring type consistency when the value is used as an array. This maintains backward compatibility as an empty array is still falsey in PHP boolean contexts.

---

99-99: Verify handling of get_frm_stylesheet filter values.

Let's verify that all consumers of the get_frm_stylesheet filter handle array values correctly.

✅ Verification successful

Let me analyze the results and generate additional verification scripts to get a complete picture.

---

Let me try a different approach to check the custom_stylesheet method using ripgrep.

---

Based on the gathered information, I can now provide the final response:

The get_frm_stylesheet filter usage is safe with empty array return value

The code handles array values correctly:

• The custom_stylesheet() method returns an array ($stylesheet_urls)
• The filter result is explicitly cast to array with $css = (array) $css
• The only usage of this filter is in FrmStylesController which properly handles both array and falsy values

🏁 Scripts executed

The following scripts were executed for the analysis:

Script:

#!/bin/bash
# Search for all usages of the get_frm_stylesheet filter
rg -A 5 "apply_filters\s*\(\s*['\"]get_frm_stylesheet" 

Length of output: 489

---

Script:

#!/bin/bash
# Let's check the implementation of custom_stylesheet() to understand the return type
ast-grep --pattern 'function custom_stylesheet() {
  $$$
}'

Length of output: 61

---

Script:

#!/bin/bash
# Search for the custom_stylesheet method definition and its context
rg -A 15 "function\s+custom_stylesheet" 

Length of output: 1064

---

Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

❤️ Share

• X
• Mastodon
• Reddit
• LinkedIn

🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

• Review comments: Directly reply to a review comment made by CodeRabbit. Example:
  • I pushed a fix in commit <commit_id>, please review it.
  • Generate unit testing code for this file.
  • Open a follow-up GitHub issue for this discussion.
• Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
  • @coderabbitai generate unit testing code for this file.
  • @coderabbitai modularize this function.
• PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
  • @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
  • @coderabbitai read src/utils.ts and generate unit testing code.
  • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
  • @coderabbitai help me debug CodeRabbit configuration file.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

• @coderabbitai pause to pause the reviews on a PR.
• @coderabbitai resume to resume the paused reviews.
• @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
• @coderabbitai full review to do a full review from scratch and review all the files again.
• @coderabbitai summary to regenerate the summary of the PR.
• @coderabbitai resolve resolve all the CodeRabbit review comments.
• @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
• @coderabbitai help to get help.

Other keywords and placeholders

• Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
• Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
• Add @coderabbitai anywhere in the PR title to generate the title automatically.

CodeRabbit Configuration File (.coderabbit.yaml)

• You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
• Please see the configuration documentation for more information.
• If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

• Visit our Documentation for detailed information on how to use CodeRabbit.
• Join our Discord Community to get help, request features, and share feedback.
• Follow us on X/Twitter for updates and announcements.